search

EFForg / badger-sett

Automated training for Privacy Badger. Badger Sett automates browsers to visit websites to produce fresh Privacy Badger tracker data.
https://www.eff.org/badger-pretraining
MIT License
119 stars 13 forks source link

docker build failed - missing domain-lists file #28

Closed iammyr closed 4 years ago

iammyr commented 5 years ago

When running ./runscan.sh for the first time, I was getting the following error

Step 23/28 : COPY domain-lists $HOME/domain-lists COPY failed: stat /var/lib/docker/tmp/docker-builder530191829/domain-lists: no such file or directory Docker build failed.

ghostwords commented 4 years ago

@bcyphers What are domain-lists? Should they just be removed from the Dockerfile?

bcyphers commented 4 years ago

those are so that you can specify your own lists of domains to scan for. it's supposed to be a directory, which can be empty. I think we can put that line behind a check for existence.

ghostwords commented 4 years ago

Ah OK. Was this fixed by 7acececc0434fb730f03fe450b021e6eb8820f45?

ghostwords commented 4 years ago

Also, how do domain-lists get used?

bcyphers commented 4 years ago

we've used them internally for a few different things, like scanning lists of the top sites from different countries. It's not used in the daily scan.

bcyphers commented 4 years ago

and yeah, 7acececc should have fixed this!