EFForg / badger-sett

Automated training for Privacy Badger. Badger Sett automates browsers to visit websites to produce fresh Privacy Badger tracker data.
https://www.eff.org/badger-pretraining
MIT License
119 stars 13 forks source link

Running with Chrome is broken #37

Closed ghostwords closed 5 years ago

ghostwords commented 5 years ago

It broke when I removed CRX2 creation from Badger's Makefile as part of the CRX3 switchover.

make: *** No rule to make target `travisbuild'.  Stop.
Traceback (most recent call last):
  File "./crawler.py", line 623, in <module>
    crawler.crawl()
  File "./crawler.py", line 373, in crawl
    self.start_browser()
  File "./crawler.py", line 320, in start_browser
    self.start_driver()
  File "./crawler.py", line 204, in start_driver
    build = subprocess.check_output(cmd).strip().decode('utf8').split()[-1]
  File "/usr/lib/python3.4/subprocess.py", line 620, in check_output
    raise CalledProcessError(retcode, process.args, output=output)
subprocess.CalledProcessError: Command '['make', '-sC', '/home/zzz/privacybadger/', 'travisbuild']' returned non-zero exit status 2

Since CRX2 is going away, the solution should be to load Privacy Badger from source ("unpacked" vs. packaged extension loading): https://github.com/EFForg/privacybadger/commit/88c862c8d278fedd7f27c9698410922b71069a5f