search

EFForg / badger-sett

Automated training for Privacy Badger. Badger Sett automates browsers to visit websites to produce fresh Privacy Badger tracker data.
https://www.eff.org/badger-pretraining
MIT License
119 stars 13 forks source link

Update of PyFunceble's version and behavior #40

Closed funilrys closed 5 years ago

funilrys commented 5 years ago

Since very recently I allowed the update of the configuration when programming on top of PyFunceble.

This patch updates to the latest version (The one which include the configuration update) and deactivates the logs sharing as mentioned at https://github.com/EFForg/badger-sett/pull/23#issuecomment-418537430.

Between because I never really answered your question, If you do a DNS lookup and get inactive and once you use PyFunceble you get active it is because I do like follow.

  1. Try to get the WHOIS record.
  2. Could we get the RECORD?
    • YES: Move to point 3.
    • NO: Move to point 4.
  3. Could we extract the expiration date from the record?
    • YES: Set the domain as ACTIVE and move to the next domain to test.
    • NO: Move to point 4.
  4. Try to do a DNS lookup.
  5. Do we get an error while trying to run the lookup?
    • YES: Set the domain as INACTIVE and move to the next domain to test.
    • NO: Set the domain as ACTIVE and move to the next domain to test.

Of course, if it is not what you want you simply have to add "no_whois": True to the newly created OUR_PYFUNCEBLE_CONFIG variable which will bypass point 1, 2 and 3 to get to point 4 directly.

Please let me know if I can help or if you need more information about PyFunceble.

Cheers, Nissar

bcyphers commented 5 years ago

Thanks for contributing! This is a very helpful explanation. And thanks for maintaining the tool as well. I'll get this merged asap.