search

EFForg / badger-sett

Automated training for Privacy Badger. Badger Sett automates browsers to visit websites to produce fresh Privacy Badger tracker data.
https://www.eff.org/badger-pretraining
MIT License
119 stars 13 forks source link

Improve logging #53

Closed ablanathtanalba closed 4 years ago

ablanathtanalba commented 4 years ago

Fixes #52 by including the most recent commit hash in the runscan.sh script terminal output, as well as logging the browser type and version in the crawler.py file.

Might circle back and reduce the amount of redundant output in both areas, but for now this is the MVP to fix the aforementioned issue.

ablanathtanalba commented 4 years ago

Ah, this makes sense! Thanks for the clarification @ghostwords

ghostwords commented 4 years ago

You should rebase the branch on master as I recently refactored how the summary section/crawl parameters output is printed. (It's now in a single place in the Crawler constructor, instead of duplicated in two versions of crawl().)

ablanathtanalba commented 4 years ago

@ghostwords will do. good call on reducing that down to a single constructor btw

ablanathtanalba commented 4 years ago

Example logging output with these changes:

Screenshot from 2020-03-10 17-06-23

ablanathtanalba commented 4 years ago

Screenshot from 2020-03-16 15-18-28 here's example output from the most recent commit, for when/if the pb checkout isnt a git directory