search

EFForg / badger-sett

Automated training for Privacy Badger. Badger Sett automates browsers to visit websites to produce fresh Privacy Badger tracker data.
https://www.eff.org/badger-pretraining
MIT License
119 stars 13 forks source link

add cli arg option for loading parallel extension #55

Closed ablanathtanalba closed 4 years ago

ablanathtanalba commented 4 years ago

fixes #54 by allowing loading of an arbitrary extension alongside privacy badger in the headless browser

ablanathtanalba commented 4 years ago

Mind taking a look at the latest commit @ghostwords ? It ought to copy the source for whatever parallel extension and then copy to the docker container, but it's not quite working and I'm not sure what I'm missing

ghostwords commented 4 years ago

Could you write out the steps for what you expect to happen?

ablanathtanalba commented 4 years ago

@ghostwords sure thing!

In my local environment, I've added a directory for any other extensions sources to live, /parallel-extensions/. I'm not sure how best to just commit a directory structure change (perhaps just adding a README to that dir? or I could commit the ublock crx that I've been testing with).

The proposed changes I've made to Dockerfile declare an environment variable for that path, then following the same logic it takes for copying the privacy badger source, I added the line COPY parallel-extensions $EXTENSIONS .

Hope this makes sense!

ablanathtanalba commented 4 years ago

I rewrote the commit history here, as it was getting a little messy.