Warn from runscan.sh when mismatch between BROWSER and --browser

EFForg / badger-sett

Automated training for Privacy Badger. Badger Sett automates browsers to visit websites to produce fresh Privacy Badger tracker data.

https://www.eff.org/badger-pretraining

MIT License

121 stars 15 forks source link

Warn from runscan.sh when mismatch between BROWSER and --browser #58

Closed ghostwords closed 9 months ago

ghostwords commented 4 years ago

Seems to be a common footgun.

ghostwords commented 9 months ago

This is fixed by 2b83673393d0a02dfc9487b693d0884ee6732889.

Since browser is now a positional/required argument, there is no longer a way to override browser after it gets set in runscan.sh.

Something like BROWSER=chrome ./runscan.sh firefox 500 will just error out immediately as it will get transformed into crawler.py chrome firefox 500.