EFForg / crocodilehunter

Taking one back for Steve Irwin     (๑•̀ㅂ•́)و
GNU General Public License v3.0
969 stars 136 forks source link

Improve application citizenship #107

Closed ThreeSixes closed 4 years ago

ThreeSixes commented 4 years ago

This PR migrates management of GPSD out of the project, adds instructions for users to configure GPSD to the documentation, made the GPSD host / port configurable in config.ini, and hopefully improves exception checking around connection errors to GPSD. Since the child process is run as a daemon we don't have a good way to catch and log the exception in the parent process but I do end up raising a RuntimeError that points to the documentation about setting GPSD up and making sure it's running. I also added some assets for using Pipenv with this project which might make it a bit easier to set up and develop against. Beyond that I made a few modifications to get some of the code closer to PEP-8 and made it a bit easier to read by cutting down line lengths.

ThreeSixes commented 4 years ago

Not ready.