Test failure depdending on initial state of homedir

EFForg / cryptobot-email

GNU Affero General Public License v3.0

61 stars 11 forks source link

Test failure depdending on initial state of homedir #23

Closed wearpants closed 10 years ago

wearpants commented 10 years ago

The following tests pass if test/homedir exist, but fail if it doesn't:

test_encrypted_pubkey_included_attached_application_pgpkeys
test_encrypted_pubkey_included_attached_text_plain
test_encrypted_pubkey_included_inline

I have a patch (soon) that resolves indeterminacy (by rm'ing test/homedir before each test), but we'll still need to fix the underlying problem. I think calling GnuPG.gen_key for each test should do the trick...

wearpants commented 10 years ago

After playing around a bit, generating a new keypair on each test is extremely slow (lack of entropy). Would a pre-generated homedir_template that gets copied fresh to homedir for each test work? Template would have a keypair for the bot, be checked into git, etc..

There is one test (GnuPGTest.test_gen_key) which needs to generate a new key; this should probably use a separate temporary homedir entirely

micahflee commented 10 years ago

Actually, this is a duplicate of #18. I'm closing this one, but you can continue commenting in the other.

And I've noticed that keygen is really really slow. Anything to speed it up is welcome :).