Fix invalid ruleset scope typings - Githubissues

EFForg / https-everywhere

A browser extension that encrypts your communications with many websites that offer HTTPS but still allow unencrypted connections.

https://eff.org/https-everywhere

Other

3.37k stars 1.09k forks source link

Fix invalid ruleset scope typings #20046

Closed cschanaj closed 3 years ago

cschanaj commented 3 years ago

This PR makes compiling scope into RegExp automatic. Pass the string literal version of the scope parameter everywhere, except for when constructing rulesets/ ~WASM calls~.

getScope expected a required string parameter, but get none. It is also called multiple time when passed to addFromJson

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring existing code
[ ] New Ruleset
[ ] Existing Ruleset

Hainish commented 3 years ago

LGTM, thanks!