Remove Cloudflare __cfduid cookie configs

EFForg / https-everywhere

A browser extension that encrypts your communications with many websites that offer HTTPS but still allow unencrypted connections.

https://eff.org/https-everywhere

Other

3.37k stars 1.09k forks source link

Remove Cloudflare __cfduid cookie configs #20071

Closed migueldemoura closed 3 years ago

migueldemoura commented 3 years ago

This cookie is no longer set for any requests proxied via Cloudflare and thus the configs that were added for it can be removed.

Further context from Cloudflare's blog: https://blog.cloudflare.com/deprecating-cfduid-cookie/

Not sure if the name attribute of <securecookie> always has to be a regex, but if not then you could simplify some of the expressions down to a straight strncmp.

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring existing code
[ ] New Ruleset
[x] Existing Ruleset

migueldemoura commented 3 years ago

Getting this in the build that failed:

ERROR src/chrome/content/rules/Placehold.it.xml: Fetch error: http://placehold.it/ => https://placehold.it/: (60, 'SSL certificate problem: certificate has expired')
ERROR src/chrome/content/rules/Placehold.it.xml: Fetch error: http://www.placehold.it/ => https://www.placehold.it/: (60, 'SSL certificate problem: certificate has expired')

This is unrelated to the PR, but the certificate they are serving at time of posting is indeed expired, should I also change the https rule?

zoracon commented 3 years ago

@migueldemoura Yes, go ahead and remove those domains from the rule. The PR should build fine afterwards.

migueldemoura commented 3 years ago

Thanks @zoracon, I've removed the placehold.it config file. Edit: one of the builds failed but it's not clear to me why that specific error would happen as a result of this change. Any ideas?