Closed clasick closed 3 years ago
This is something I also experience locally. I will investigate.
This is something I also experience locally. I will investigate.
Let me know if you need any help debugging the issue or validating a potential fix. 🤠
This is something I also experience locally. I will investigate.
Let me know if you need any help debugging the issue or validating a potential fix. cowboy_hat_face
Upon looking into test/script.py
, Firefox allows the needed load time for the extension and it seems Chrome now needs that same caveat. If you place: time.sleep(1)
in the same place as where the Firefox section has, It loads and then redirects properly. Which calls https://github.com/EFForg/https-everywhere/issues/11793, where it seems we were never sure why this was needed. I will see if I can investigate if this is a race condition of Selenium webdriver or considered environmental on browser load times and conditions.
So there's a temporary solution I can place if I do not find out the real problem in a timely fashion.
This is something I also experience locally. I will investigate.
Let me know if you need any help debugging the issue or validating a potential fix. cowboy_hat_face
Upon looking into
test/script.py
, Firefox allows the needed load time for the extension and it seems Chrome now needs that same caveat. If you place:time.sleep(1)
in the same place as where the Firefox section has, It loads and then redirects properly. Which calls #11793, where it seems we were never sure why this was needed. I will see if I can investigate if this is a race condition of Selenium webdriver or considered environmental on browser load times and conditions.So there's a temporary solution I can place if I do not find out the real problem in a timely fashion.
Thanks for the update! Adding time.sleep(1)
makes the test pass. It must definetely be a driver initialization race condition as you've mentioned.
Type: Testing
Testing on a fresh Ubuntu 20.04 machine. The install dependencies script passes with no errors or warnings. The Firefox test passes as well, but the Chrome test alone fails with the following error:
Are there any additional steps to be done before running the test suite other than installing dependencies or is the suite just broken in general?