search

EFForg / https-everywhere

A browser extension that encrypts your communications with many websites that offer HTTPS but still allow unencrypted connections.
https://eff.org/https-everywhere
Other
3.37k stars 1.1k forks source link

Fixcppcheck1.osuosl.org:8000 #20152

Closed guillaume-uH57J9 closed 2 years ago

guillaume-uH57J9 commented 2 years ago

Fixes #20151

Type of change

guillaume-uH57J9 commented 2 years ago

@zoracon with pleasure. done!

guillaume-uH57J9 commented 2 years ago

The one automated test that fails is because of a timeout when accessing https://oprod-controller1.osuosl.org/ cf https://app.travis-ci.com/github/EFForg/https-everywhere/jobs/549573382

The change I have submitted does not touch this subdomain, and is not causing this error. Please consider accepting it.

I did check and this URL load for me https://oprod-controller1.osuosl.org/ so I guess it was either temporarily unavailable during the test, or there may be a different kind of network issue between that subdomain and the CI server.

Edit: now that I think of it, I suspect there is rate limiting in effect on this server. I recently had connection failure with another subdomain after making several queries. It's possible CI is running into rate limiting on the remote server

guillaume-uH57J9 commented 2 years ago

I made a typo in a previous commit message (confusion between hostnames) so I amended it