Closed lqf96 closed 9 years ago
@lqf96 You mean #2030? Before you create pull request, you can test it yourself. Assuming you're on Linux environment, in https-everywhere folder, bash fetch-test.sh src/chrome/content/rules/Taobao.xml
My suggestions: Taobao.xml
rule from to
for every target host
. A single <rule from="^http:" to="https:" />
is sufficient.assets.taobaocdn.com
and s.tbcdn.cn
. They are no longer valid and have been replaced with *.alicdn.com
. One way to test the URL is curl -I -L https://s.tbcdn.cn
.<securecookie host="^\.login\.m\.taobao\.com$" name=".+" />
with <securecookie host="^.*\.taobao\.com$" name=".+" />
to apply to *.taobao.com
instead of just login.m.taobao.com
.Pull request
I notice you create a pull request from your master
branch which includes three files change. I suggest to create separate pull request for each file/ruleset. The reason is because how-old.net.xml
and ppy.sh.xml
might not have any issue, however issue of Taobao.xml
prevents those two ruleset from getting merged if you put them in one pull request.
How to create separate pull request? Instead of:
master branch:
how-old.net.xml
ppy.sh.xml
Taobao.xml
Pull request your repo:master
vs. EFForg:master
why not,
how-old branch:
how-old.net.xml
Pull request your repo:how-old
vs. EFForg:master
and so on.
It seems that taobao and tmall has added full https support on nearly all their subdomains. however i have some problems writing a ruleset (build always failed). So please add rules for these sites, thank you.