HTTPS Everywhere extension for Microsoft Edge

martinsuchan commented 8 years ago

Microsoft released in July 2016 Windows 10 Anniversary Update which comes with a new version of Microsoft Edge browser that supports Extensions. These extensions use similar structure and API as Chrome extensions - porting the existing HTTPS Everywhere extension should be then really easy.

Documentation for developing Edge extensions is available here:
https://developer.microsoft.com/en-us/microsoft-edge/platform/documentation/extensions/

TheRyuu commented 8 years ago

Just to update the AU is now out for Windows 10 and so is the documentation for developing extensions[1]. Hopefully minimal modifications are required since it is just the WebRequest API with some minor technical differences to Chrome's.

Just for reference uBlock Origin requires minimal changes to get it working[2].

[1] https://developer.microsoft.com/en-us/microsoft-edge/platform/documentation/extensions/ [2] https://github.com/gorhill/uBlock/pull/1486#issuecomment-234380212

jeremyn commented 8 years ago

The current HTTPS-Everywhere development and build process is *nix-centric. I was recently told here that people using Windows 10 who want to contribute to HTTPS-Everywhere need to use some sort of Linux VM. However the equivalent of ChromeDriver for Edge, WebDriver, which allows for command-line browser testing, must be installed on Windows 10. So it seems to me that the build process needs to be made to work on Windows 10, or at least a parallel build process just for Edge needs to be created, before an Edge extension could be created.

Artoria2e5 commented 8 years ago

MS Edge uses the common WebExtensions API, which is used by Opera as well. For me it's fine to have the tests come later than the proof of concept alphas.

P.S. WebDriver is also a common W3C API.

Regarding the conversion tool, It looks generally like a lint tool that also adds a bridge for the chrome object. Attached is a sample of its bridge scripts, generated for Stylish 1.3.1-1. (Warning: heavy use of ES6.) bridge.zip

dxgldotorg commented 7 years ago

Probably want to boycott the Windows DRM store: https://arstechnica.com/gaming/2017/04/microsoft-formally-bans-emulators-on-xbox-windows-10-download-shops/ Or perhaps publish it as a sideloaded extension? https://docs.microsoft.com/en-us/microsoft-edge/extensions/guides/adding-and-removing-extensions

martinsuchan commented 7 years ago

Note that Windows 10 Creators Update was just released and it contains even wider API set for Edge Extensions:
https://docs.microsoft.com/en-us/microsoft-edge/extensions/api-support/extension-api-roadmap

elyscape commented 7 years ago

@WilliamFeely I don't see how that's relevant to the purpose of this extension.

dxgldotorg commented 7 years ago

If HTTPS Everywhere were to divest itself of EFF, it would be a non-issue, but the latter gives instructions on how to install extensions outside of the Store.

jeremyn commented 7 years ago

Let's not turn this into a discussion about boycotting Windows or Edge. HTTPS Everywhere means providing HTTPS rewrite protection wherever possible, including on Edge.

I believe @Hainish has the WebExtension rewrite on his to-do list. If anyone wants to help make HTTPS Everywhere available on Edge, that effort is welcome, and they should coordinate their work with him.

xt0rted commented 7 years ago

I was trying to get Stylus working in Edge and ran into a number of issues where html5 templates & the extensions api aren't feature complete compared to Chrome, even in v15 which was released this/next week.

I'm not sure if templates are used anywhere but the DocumentFragment api is only partially implemented so properties like .firstElementChild don't work.

The extensions api I had issues with was

chrome.tabs.query({ currentWindow: true }, function(tabs) { ... });

When the currentWindow option is set to true, even with other options, the result is always undefined. Setting it to false returns a result, but that's not how either plugin is using it so it's a blocking issue. I reached out to the Edge team about this and they passed the question on to a team member to look into and confirm if it's a bug, but I haven't heard anything on it yet.

robinhood2014 commented 7 years ago

Well, this is not good. I replaced every instance of "chrome.xxx" (where "xxx" represents functions of Google Chrome) with "myBrowser.xxx", and even removed all comments from all JavaScript files referenced in manifest.json, and the Edge Extension Toolkit is still reporting manifest.json as malformed. HTTPS Everywhere Prototype.zip

Artoria2e5 commented 7 years ago

The toolkit does some heavy linting on the manifest. Have you checked for errors around things like the icon stuffs?

robinhood2014 commented 7 years ago

According to the toolkit, only the manifest file has errors.

Artoria2e5 commented 7 years ago

I fed the 2017.4.5 directory to the toolkit. This time it spits out the error as:

manifest.json  .author : invalid type: object (expected string)

The current value provided is in fact a violation of WebExtentions Spec, as per https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/author. Fixing that gives a "ready to go" message for the extension.

gloriousjob commented 7 years ago

Hi all,

I created this zip and it seems to work on my machine. Just extract it and sideload the extension. https_everywhere_edge.zip

The process I followed was fairly simple (though it took a few tries to figure out and get working):

Extracted the chrome extension.
Opened manifest.json and made the following changes: a. changed author to "author": "eff.software.projects@gmail.com" since braces are non-standard (https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/author) b. Added the following subproperty to "background": ,"persistent": true c. Added the following property: "locale": "en" d. Added the following property: "minimum_edge_version": "33.14281.1000.0"
Opened all js files with chrome references and placed this code at the top: if (typeof msBrowser !== 'undefined') { chrome = msBrowser; } else if (typeof browser !== 'undefined') { chrome = browser; }

elyscape commented 7 years ago

@gloriousjob Why are you using !== for checking typeof msBrowser but != for typeof browser?

saschanaz commented 7 years ago

@gloriousjob Why msBrowser? I think Edge uses browser.

gloriousjob commented 7 years ago

@elyscape Good call! I copied that code from elsewhere which said that is what MS was doing. It makes sense to do an actual equals there. I've updated my previous comment and uploaded a new zip.

@SaschaNaz I've read that Edge was using msBrowser and browser is where the browsers are trying to standardize to. It's safer to have both just in case. If msBrowser is wrong, the if statement will skip it anyway.

gmng commented 7 years ago

I tried gloriousjob's zip and loaded the folder in EDGE but it does not redirect the link what I tried to HTTPS. It was an http link in a gmail mail but it does not redircted it to the https proto. (the page has https access too, I tried it manually in the address bar)

elyscape commented 7 years ago

@gmng Does HTTPS Everywhere redirect the site in question when using Chrome?

gmng commented 7 years ago

@elyscape No, it doesn't. I use this extension in FF with no problem, and now I installed it in chrome to test, but no, it does not redirect the page. It's a parcel tracking page (GLS) and has both http and https access. Same behaviour like in EDGE, when I insert the link in plain HTTP it doesn't redirect to https. When I change the proto manually to httpS in the address bar, I can access the page over SSL.

gloriousjob commented 7 years ago

@elyscape thanks for asking the question @gmng so the edge extension I made is just a port of the chrome extension. This is really an issue with the chrome extension. Maybe you should write up a separate issue?

On April 22, 2017 3:53:12 AM gmng notifications@github.com wrote:

@elyscape No, it doesn't. I use this extension in FF with no problem, and now I installed it in chrome to test, but no, it does not redirect the page. It's a parcel tracking page (GLS) and has both http and https access. Same behaviour like in EDGE, when I insert the link in plain HTTP it doesn't redirect to https. When I change the proto manually to httpS in the address bar, I can access the page over SSL.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/EFForg/https-everywhere/issues/5101#issuecomment-296355898

jeremyn commented 7 years ago

If anyone wants to let people know about a site that needs an HTTPS Everywhere redirect, you can just note it in issue https://github.com/EFForg/https-everywhere/issues/3069.

nicole-ashley commented 7 years ago

@gloriousjob msBrowser is not used by Edge, it can be removed entirely.

What are the next steps now for Edge support?

martinsuchan commented 7 years ago

So what's the status of the extension for Edge, any blockers I can help with or ETA when it could be ready?

craige1 commented 7 years ago

With the converter and the steps gloriousjob did, it seems extremely easy to make this. Can i push for this to be put into the store officially?

jeremyn commented 7 years ago

@Hainish has authority here and I don't want to step on his toes, but, just to set expectations, right now I believe the big technical focus is on converting the XUL/XPCOM version of the Firefox extension to use WebExtensions in time for the Firefox 57 release where XUL/XPCOM extensions won't work anymore. See here for related tagged issues. Once the Firefox migration is public and settled then @Hainish / the EFF might decide to work on the Edge version. Firefox 57 is due out in November 2017 so Edge might not have priority until then at least.

Hainish commented 7 years ago

Thanks @jeremyn. In addition, our legal department needs to look at whether we are able to comply with the MS developer license agreement.

dxgldotorg commented 7 years ago

@Hainish Could the issue with the developer agreement be resolved by making the HTTPS lists an external download, so as there are no hard-coded references to domains whose content may violate the Agreement or may even contain legal violations?

craige1 commented 7 years ago

Thanks for getting back to me. Its actually great news that this is being looked into. I understand that the dev work priority will lie with the current plugins, I just wanted to check in to see that an edge plugin wasn't being ignored, or forgotten. Here's to hoping the legal issues aren't an issue (how are the play store and apple store dealt with?).

martinsuchan commented 7 years ago

Once there is working beta of the extension I'd suggest creating Windows Store account and submitting the extension for test using this form:
https://developer.microsoft.com/en-us/microsoft-edge/extensions/requests/ Microsoft will then contact you with details and necessary info to get the extension into Store.

And since there is Windows 10 Fall Creators Update planned for September/October this year, it would be nice to have HTTPS Everywhere as a highlighted Edge extension when this Windows update is released.

uncnqrd commented 7 years ago

Is the main issue blocking a version for Edge the MS developers license agreement? Or is there a technical issue, such as specific API support missing?

dxgldotorg commented 7 years ago

I do not believe there is any license issue preventing creating an addon, just in submitting it to the Store, which does have various rules on what kind of software is and is not allowed.

nicole-ashley commented 7 years ago

Knowing their rules I don't believe this would be blocked, in fact it would be welcomed. You just need to apply for permission to launch Edge extensions at the moment

I publish uBlock for Edge and have an existing relationship with the team. I'd be happy to do it for this, though it would be under my personal name if that was the case, and I would need to upload all the releases. If it was to be done under the Foundation's name then someone would need to apply for a Company account and go through Verisign verification.

jeremyn commented 7 years ago

I assume the blocking problem here is that the one person who could make this happen officially -- @Hainish -- isn't interested, or at least has made an Edge extension low priority vs everything else.

I suggest anyone who wants this done on any definite schedule either become big enough for the EFF to listen, or fork/repackage the code.

Regarding a fork, take a look at issue https://github.com/EFForg/https-everywhere/issues/12606 "Discussion about out-of-band ruleset updates". The EFF wants to move to a model where the extension regularly fetches EFF-signed updates from the internet outside the browser update process. I encourage anyone who is considering a project fork, even for their own personal use, to participate in that discussion.