EFForg / privacybadger

Privacy Badger is a browser extension that automatically learns to block invisible trackers.
https://privacybadger.org
Other
3.16k stars 382 forks source link

vidible.tv breaks video #1238

Closed terrorist96 closed 7 years ago

terrorist96 commented 7 years ago

http://www.wxyz.com/news/see-two-masked-open-carry-activists-walk-in-dearborn-police-armed-with-ar-15-handguns

The following need to be moved to yellow to fix the video. cdn.vidible.tv delivery.vidible.tv

terrorist96 commented 7 years ago

http://www.abc2news.com/news/region/baltimore-county/baltimore-co-leaders-repeal-ban-on-tasers-stun-guns

ghostwords commented 7 years ago

Should probably get yellowlisted.

terrorist96 commented 7 years ago

http://www.nydailynews.com/entertainment/music/mobb-deep-rapper-prodigy-dead-42-article-1.3262918

cdn.vidible.tv delivery.vidible.tv trk.vidible.tv

ghostwords commented 7 years ago

More examples:

terrorist96 commented 7 years ago

@ghostwords despite being on the yellow list.... image What's going on here?

**** ACTION_MAP for vidible
VM857:5 cdn.vidible.tv {
  "dnt": false,
  "heuristicAction": "",
  "nextUpdateTime": 1507765599450,
  "userAction": ""
}
VM857:5 delivery.vidible.tv {
  "dnt": false,
  "heuristicAction": "block",
  "nextUpdateTime": 1507349303674,
  "userAction": ""
}
VM857:5 img.vidible.tv {
  "dnt": false,
  "heuristicAction": "",
  "nextUpdateTime": 1493075204123,
  "userAction": ""
}
VM857:5 newsy-vidible-ovp1.vemba.io {
  "dnt": false,
  "heuristicAction": "",
  "nextUpdateTime": 1492949781791,
  "userAction": ""
}
VM857:5 trk.vidible.tv {
  "dnt": false,
  "heuristicAction": "",
  "nextUpdateTime": 1507732697887,
  "userAction": ""
}
VM857:5 vidible.tv {
  "dnt": false,
  "heuristicAction": "block",
  "nextUpdateTime": 1492938167561,
  "userAction": ""
}
VM857:7 **** SNITCH_MAP for vidible
VM857:9 vidible.tv [
  "yibada.com",
  "huffingtonpost.com",
  "wistv.com"
]
ghostwords commented 7 years ago

vidible.tv was added to the yellowlist on August 21st; the most recent error report that blocks it is from August 22nd, which makes sense. But you are clearly running into some kind of yellowlist-related bug. Previously: https://github.com/EFForg/privacybadger/issues/1588#issuecomment-332410569. It seems like your issue would be related to the most recent Privacy Badger update, but maybe not. I'll keep looking ... We already found one new bug.

terrorist96 commented 7 years ago

Yeah. And again, the reported issue here was fixed (vidible defaulted to yellow). But it reverted to red after some time.

ghostwords commented 7 years ago

Which domains do you see printed when you run the following on Badger's background page?

(function () {
  let am = badger.storage.getBadgerStorageObject('action_map'),
    ylist = badger.storage.getBadgerStorageObject('cookieblock_list').getItemClones();
  for (let domain in ylist) {
    if (am.getItem(domain) && am.getItem(domain).heuristicAction == "block") {
      console.log(domain);
    }
  }
}());

This looks for all yellowlisted yet blocked domains.

terrorist96 commented 7 years ago
VM896:6 content.jwplatform.com
VM896:6 play.google.com
VM896:6 sites.google.com
VM896:6 storage.googleapis.com
VM896:6 swiftype.com
VM896:6 unicornmedia.com
VM896:6 vidible.tv
VM896:6 wikipedia.org
ghostwords commented 7 years ago

I'm guessing your Badger ran out of chrome.storage.local space. Makes sense: we previously ran into space-related data export issues (https://github.com/EFForg/privacybadger/issues/1318#issuecomment-294939853). This means any changes you or Privacy Badger make at this point fail to survive browser/extension restarting. Which explains why you would see domains get cookieblocked and then reverted to their previous setting. Your Badger learns about new domains as you browse, but forgets all the new learning after getting restarted.

Do you see any relevant errors in the background page's console? If this is indeed the issue, I should be able to get it fixed with the next Badger update.

terrorist96 commented 7 years ago

Do you see any relevant errors in the background page's console? If this is indeed the issue, I should be able to get it fixed with the next Badger update.

I always see errors there. Here's a snippet: image

ghostwords commented 7 years ago

Ah yes, that's it, we got it! I'll open a ticket in a bit. Looks like your Badger ran out of storage sometime between df498dc646b8de516505ac2625dc885a203ea6c6 in February and 47bb1d639c23993f96e0f7d4cb718cb681e575e6 in June.

Any errors besides "Failed to load resource" errors (these are failed DNT policy checks, I don't think we can hide them unfortunately) are not expected.