EFForg / privacybadger

Privacy Badger is a browser extension that automatically learns to block invisible trackers.
https://privacybadger.org
Other
3.19k stars 386 forks source link

Can't figure out how to make PB unblock the "Todoist" gmail plugin #1491

Open jowens opened 7 years ago

jowens commented 7 years ago

I am running PB on OS X / Chrome. I installed the "Todoist" gmail plugin:

https://chrome.google.com/webstore/detail/todoist-for-gmail/clgenfnodoocmhnlnpknojdbjjnmecff?hl=en

I cannot see the Todoist button in regular mode, but when I allow the Todoist extension in incognito mode and do not allow PB in incognito mode, I can see the button again.

Todoist support suggests whitelisting todoist.com and cloudfront.net. I have done this:

privacy_badger_options

When I look at the HTML in the Chrome editor where the Todoist button appears, it looks like this:

<div class="T-I J-J5-Ji ar7 L3 inboxsdk__button T-I-ax7 T-I-Js-Gs" role="button" tabindex="0" data-tooltip="Add to Todoist" data-thread-toolbar="true" data-add-button-debug="{&quot;id&quot;:&quot;1499964822160-0.7594765347822972-Add to Todoist&quot;,&quot;title&quot;:&quot;Add to Todoist&quot;,&quot;hasThreadViewDriver&quot;:true,&quot;hasRowListViewDriver&quot;:false}"><div><div class="inboxsdk__button_icon"><img class="inboxsdk__button_iconImg" src="https://d2dq6e731uoz0t.cloudfront.net/fe07bb3867f357d46d5760f521e2969c/as/todoist.svg"></div><span class="inboxsdk__button_text">Add to Todoist</span></div></div>

Here is a picture of regular mode (notice 2 <div> elements, "Move to" and "Labels"):

developer_tools_-_https___mail_google_com_mail_u_1_

and incognito mode (3 <div> elements):

developer_tools_-_https___mail_google_com_mail_u_0_

The <div> associated with the Todoist button is just gone, presumably filtered out by PB.

Any way I can convince PB to allow this button to appear?

ghostwords commented 7 years ago

Could you try whitelisting mail.google.com (or whatever your Gmail domain is) instead?

jowens commented 7 years ago

That actually does fix it! Kind of defeats the purpose of PB if I have to whitelist mail.google.com, but yes, that fixes it.

ghostwords commented 7 years ago

I think disabling Privacy Badger on a few sites is OK, since the purpose of Badger is to prevent companies from non-consensually following you across the entire Web.

Does Badger report any Todoist-related domains on your Gmail page?

jowens commented 7 years ago

Forgive my ignorance here, but how would I tell what domains Badger would report on my gmail page?

ghostwords commented 7 years ago

You can see what domains Badger reports as blocked (red), partially allowed (yellow), or allowed (green) by clicking on Badger's button in your browser's toolbar. You'll have to first temporarily re-enable Badger for the site and reload the page to see the domains though.

ghostwords commented 7 years ago

Also, I think our Whitelisted Domains text can use some improvement. It seems like "disabled for the domains listed below" is too open for interpretation. The "Disable Privacy Badger for This Site" button in the popup does seem clear, on the other hand.

jowens commented 7 years ago

Green: mailfoogae.appspot.com Yellow: fonts.googleapis.com Red: www.inboxsdk.com Red: cdn.ravenjs.com Green: www.streak.com Green: gmail.todoist.com Green: xcomet05.todoist.com

does not appear to be tracking you: Green: d3ptyyxy2at9ui.cloudfront.net

ghostwords commented 7 years ago

Cool, thank you.