EFForg / privacybadger

Privacy Badger is a browser extension that automatically learns to block invisible trackers.
https://privacybadger.org
Other
3.15k stars 382 forks source link

pb breaks mightytext sms in gmail #2044

Open ohadh opened 6 years ago

ohadh commented 6 years ago

despite whitelisting mightytext in pb settings, mightytext unable to "log in" or send sms from gmail when pb is active. mightytext has been unable to rectify.

screenshot of whitelisting attached untitled

ghostwords commented 6 years ago

Does it help if you search for these domains in the Tracking Domains tab, and move their sliders to yellow or green?

ohadh commented 6 years ago

yes!!! thank you! :)

ghostwords commented 6 years ago

Excellent! I think we need to make it more clear when you want to use Whitelisted Domains and when you want to use Tracking Domains. This might be a form description and/or naming issue.

ghostwords commented 6 years ago

Regarding the MightyText conflict, could you run the following script in your Badger's background page console and share what it prints out?

(function () {
  const STR = "mightytext";
  console.log("**** ACTION_MAP for", STR);
  _.each(badger.storage.getBadgerStorageObject('action_map').getItemClones(), (obj, domain) => {
    if (domain.indexOf(STR) != -1) console.log(domain, JSON.stringify(obj, null, 2));
  });
  console.log("**** SNITCH_MAP for", STR);
  _.each(badger.storage.getBadgerStorageObject('snitch_map').getItemClones(), (sites, domain) => {
    if (domain.indexOf(STR) != -1) console.log(domain, JSON.stringify(sites, null, 2));
  });
}());
(function () {
  const STR = "appspot";
  console.log("**** ACTION_MAP for", STR);
  _.each(badger.storage.getBadgerStorageObject('action_map').getItemClones(), (obj, domain) => {
    if (domain.indexOf(STR) != -1) console.log(domain, JSON.stringify(obj, null, 2));
  });
  console.log("**** SNITCH_MAP for", STR);
  _.each(badger.storage.getBadgerStorageObject('snitch_map').getItemClones(), (sites, domain) => {
    if (domain.indexOf(STR) != -1) console.log(domain, JSON.stringify(sites, null, 2));
  });
}());

To get to the background page console in Chrome, visit chrome://extensions, make sure "Developer mode" is checked, click on the "background page" link in Privacy Badger's row, and select the Console tab.

In Firefox, visit about:debugging, enable add-on debugging, click Debug next to Privacy Badger, click the OK button on the popup warning about remote debugging, and enter the above script into the console after the >>.

ohadh commented 6 years ago

this is the output

VM146:3 **** ACTION_MAP for mightytext
VM146:5 mightytext.net {
  "dnt": false,
  "heuristicAction": "allow",
  "nextUpdateTime": 1527124446697,
  "userAction": ""
}
VM146:7 **** SNITCH_MAP for mightytext
VM146:9 mightytext.net [
  "google.com",
  "google.co.il"
]
VM146:14 **** ACTION_MAP for appspot
VM146:16 textyserver.appspot.com {
  "dnt": false,
  "heuristicAction": "cookieblock",
  "nextUpdateTime": 1527099100807,
  "userAction": "user_allow"
}
VM146:18 **** SNITCH_MAP for appspot
VM146:20 textyserver.appspot.com [
  "mightytext.net",
  "google.com",
  "google.co.il"
]
undefined
bcyphers commented 5 years ago

Since appspot.com is such a ubiquitous host (it's the etld of Google App Engine), it might be worth adding to the ETLD list. Need to check error reports to investigate further.