EFForg / privacybadger

Privacy Badger is a browser extension that automatically learns to block invisible trackers.
https://privacybadger.org
Other
3.08k stars 379 forks source link

Suggestion: Strip tracking from out.reddit.com #2194

Open jleclanche opened 5 years ago

jleclanche commented 5 years ago

Reddit mangles links in its new UI.

For example, if I click here:

https://www.reddit.com/r/books/comments/9nl70u/incarcerated_pennsylvanians_now_have_to_pay_150/

And then I click on the URL: image

It redirects me to https://out.reddit.com/t3_9nixiz?url=https%3A%2F%2Fwww.washingtonpost.com%2Famphtml%2Fopinions%2Fincarcerated-pennsylvanians-now-have-to-pay-150-to-read-we-should-all-be-outraged%2F2018%2F10%2F11%2F51f548b8-cbd9-11e8-a85c-0bbe30c19e8f_story.html&token=XXXXXXXXXXXXXXXXXXXXXXXXXXXX-XXXXXXXXXXX&app_name=desktop2x&user_id=XXXXXXX

This behaviour can be disabled in the Privacy settings if you have an account: https://www.reddit.com/settings/privacy

image

bcyphers commented 5 years ago

Thanks for pointing this out! This should be pretty simple to do given the infrastructure from #2016.

mijiturka commented 5 years ago

I've made a change here that seems to work (based on my manual testing in Firefox and Chrome). Working on adding unit tests now.

bcyphers commented 5 years ago

Thanks @mijiturka. When you're happy with it, make a pull request and assign me as the reviewer.

jleclanche commented 4 years ago

@mijiturka @bcyphers was this ever merged in?

ghostwords commented 3 years ago

I can't reproduce Reddit link redirection at this time without an account. If this is still a thing, does it only happen for logged in users? If so, can you still opt out by visiting Reddit's privacy settings?

ghost commented 3 years ago

This still happens without an account. It affects the main www.reddit.com site, not old.reddit.com

The opt-put in the account settings works as expected on the main site when logged in.

Page used to test: https://www.reddit.com/r/DataPolice/comments/hqlygx/eff_launches_searchable_database_of_police/