Soundcloud widgets are not reliably replaced

[tjhietala]

Soundcloud widget replacement does not seem to be working reliably.

Works here: https://soundcloud.com/pages/embed

Fails here (as an example): https://www.kvraudio.com/forum/viewtopic.php?f=14&t=521921&sid=e014f2dd651d6e75b9021d9265b2d7ef

Possibly related to #787

[ghostwords]

Hello! Thanks for the report.

Looks like this forum uses a custom loading solution for (SoundCloud) embeds. I think the page includes JavaScript that looks for SoundCloud links and appends the appropriate embed to each. The problem is that our replacement code runs before this replacement happens and doesn't run again so it misses the widget. (The replacement seems broken both when soundcloud.com is cookieblocked and when it is blocked.)

Basically our widget replacement doesn't yet work with custom embed loaders (https://github.com/EFForg/privacybadger/pull/2262#issuecomment-451493405).

[ghostwords]

This one is replaced, sort of, but fails to activate on click: https://postlight.com/trackchanges/podcast/accountability-tools:-paul-and-rich-on-how-they-stay-on-track

Similar use of oEmbed as in the forum link in original report above: https://www.asoundeffect.com/sound-library/bass-drops-downers-vol-2/

Loaded by Embedly, missing activate buttons (??) : https://www.kickstarter.com/projects/vontheodore/orange-island/posts/3922888

Dynamically loaded, hidden, API-controlled players get replaced but the placeholders are also invisible: https://www.uvi.net/en/vintage-corner/digital-synsations.html#listen https://www.milkenarchive.org/music/volumes/view/great-songs-of-the-american-yiddish-stage/work/bay-mir-bistu-sheyn/ https://www.glyndebourne.com/festival/podcast-madama-butterfly/ https://teganandsara.com/music/