search

EFForg / privacybadger

Privacy Badger is a browser extension that automatically learns to block invisible trackers.
https://privacybadger.org
Other
3.19k stars 386 forks source link

Show Chromium users how to pin extension in toolbar #2983

Closed lenacohen closed 4 months ago

lenacohen commented 5 months ago

Encourage Chrome users to pin Privacy Badger to their toolbar by: 1) Adding information about how and why to pin the extension 2) Adding an arrow pointing to where they can click to pin the extension

Test by running branch in Chrome to see changes (make runch) and another browser to confirm nothing changed (make runff)

Seeking feedback on the design and language, especially for the arrow.

Also, following up on #2959 and d1a748cec47ebad30e3d49c8356fcdb04b35ecd3, I fixed a UI bug I noticed with the Share icons on narrow screens:

Screenshot 2024-06-13 at 6 13 03 PM

Part of #2781

lenacohen commented 4 months ago

I don't love the popup message but I'm still thinking about alternatives. I'm worried the "Disable for this site" reference needs more context or is too specific, since it's not all the popup has. Here's one alternative that's a bit longer:

lenacohen commented 4 months ago

Thank you! Left some feedback inline, plus:

  • Is the puzzle piece icon also unused?
  • The overlay should appear on the left w/ RTL locales. Let's flip the image in the overlay too.
  • Does running any new images through https://imageoptim.com/mac help save space?
  • We could also use a placeholder for "Disable for this site" in '... access to the "Disable for this site" button'. Then, we won't have to worry about having the translation here and in the popup being in sync.
  • I wonder if we should gray out the rest of the page to draw attention to, and to force interaction with the overlay. Kind of like what happens in the popup when badger.criticalError is set in the background process. I am not sure if we should, just concerned whether the overlay is too easy to ignore. The orange hero background, plus the "Take the tour" CTA button, plus the social sharing buttons vs. the gray overlay, you know?
  • Maybe the X should be smaller?

Thanks for the feedback! I removed the unused puzzle piece icon and ran the new images through imageoptim. I like the gray background while the nudge is showing!