"callback not defined" console error after ShareMeNot merge

[diracdeltas]

ex:

console.error: privacybadgerfirefox: 
  Message: TypeError: callback is undefined
  Stack:
    onEvent@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/yan/.mozilla/firefox/PROFILE/extensions/jid1-MnnxcxisBPnSXQ@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/loader/sandbox.js -> resource://gre/modules/commonjs/sdk/content/content-worker.js:45:9onEvent@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/yan/.mozilla/firefox/PROFILE/extensions/jid1-MnnxcxisBPnSXQ@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/loader/sandbox.js -> resource://gre/modules/commonjs/sdk/content/content-worker.js:45:9
onChromeEvent@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/yan/.mozilla/firefox/PROFILE/extensions/jid1-MnnxcxisBPnSXQ@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/loader/sandbox.js -> resource://gre/modules/commonjs/sdk/content/content-worker.js:96:9

[diracdeltas]

another console error:

console.error: privacybadgerfirefox: 
  Message: TypeError: value is not a non-null object
  Stack:
    exports.getSocialWidgetContentScriptData/<@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/yan/.mozilla/firefox/PROFILE/extensions/jid1-MnnxcxisBPnSXQ@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://jid1-mnnxcxisbpnsxq-at-jetpack/privacybadgerfirefox/lib/socialWidgetHandler.js:63:1
exports.getSocialWidgetContentScriptData@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/yan/.mozilla/firefox/PROFILE/extensions/jid1-MnnxcxisBPnSXQ@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://jid1-mnnxcxisbpnsxq-at-jetpack/privacybadgerfirefox/lib/socialWidgetHandler.js:58:3

[diracdeltas]

@froeschele do you have time to look at this issue?

[froeschele]

Sure, I'll take a look.

[diracdeltas]

Cool, I have a fix to the second error (value is not a non-null obj).

[diracdeltas]

Pull request for the latter error: https://github.com/EFForg/privacybadgerfirefox/pull/166

[froeschele]

Looking at the first error now, but I can't seem to get it to show up. When does it happen?

[diracdeltas]

@froeschele I can usually get it to show up by running cfx test, then going to:

1. http://sharemenot.cs.washington.edu/Test%20Installation.shtml#.U8BKPKbyaCg
2. http://www.theguardian.com/uk
3. http://www.theverge.com/
4. http://www.nytimes.com/

in new tabs

[froeschele]

Ah, I got it. Nondeterministic because it was due to a race condition. Pull request with fix: #168

[mmcco]

I'm experiencing something like this on Firefox 37.0.1 with Privacy Badger 0.2.6. I'm on OpenBSD-current, which could be a complicating factor.

Firefox's console output contains lots of errors like this:

console.error: privacybadgerfirefox: 
  Message: TypeError: value is not a non-null object
  Stack:
    getTabForBrowser@chrome://browser/content/tabbrowser.xml:430:18
_getTabForContentWindow@chrome://browser/content/tabbrowser.xml:392:1
getBrowserForDocument@chrome://browser/content/tabbrowser.xml:364:23
getTabForChannel@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/mike/.mozilla/firefox/tv6zl066.default/extensions/jid1-MnnxcxisBPnSXQ@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://jid1-mnnxcxisbpnsxq-at-jetpack/privacybadgerfirefox/lib/utils.js:121:39
updateCountForChannel@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/mike/.mozilla/firefox/tv6zl066.default/extensions/jid1-MnnxcxisBPnSXQ@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://jid1-mnnxcxisbpnsxq-at-jetpack/privacybadgerfirefox/lib/ui.js:170:15
onModifyRequest@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/mike/.mozilla/firefox/tv6zl066.default/extensions/jid1-MnnxcxisBPnSXQ@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://jid1-mnnxcxisbpnsxq-at-jetpack/privacybadgerfirefox/lib/main.js:39:5
Observer<.observe@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/mike/.mozilla/firefox/tv6zl066.default/extensions/jid1-MnnxcxisBPnSXQ@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/system/events.js:72:7

At least at first glance, it appears that they're all the same. I'm also using NoScript, which may be interfering. All of my addons are up-to-date.

Let me know if I should open a new ticket.

[cooperq]

@plsql can you try building privacy badger from master and see if this error persists? I think I might have fixed this particular one.

[mmcco]

@cooperq I tried it using the instructions in the repo, browsed around a little, blocked a few trackers, and didn't see the error again. Thanks for that! Is the fix going to be included in the next release?

[cooperq]

it will! thanks!