EFForg / privacybadgerfirefox-legacy

LEGACY Privacy Badger for Firefox SEE README
https://www.eff.org/privacybadger
Other
408 stars 68 forks source link

No PB icon in toolbar on GNU Icecat 24 and Firefox 29 #57

Closed salut-c-leo closed 10 years ago

salut-c-leo commented 10 years ago

I tried to activate, deactivate Privacy Badger, nothing appears. The extension is installed.

garrettr commented 10 years ago

Can you give a more precise set of Steps to Reproduce (STR), starting with how you installed the addon? After installation, a "first run" page should pop up with some info about the addon, and you should see an icon added to the toolbar in the top right of the screen.

salut-c-leo commented 10 years ago

I installed the addon via eff.org/privacybadger. After installation, the first run popup appeared but no logo on Firefox bar.

diracdeltas commented 10 years ago

Can you see Privacy Badger in about:addons?

salut-c-leo commented 10 years ago

Yes.

salut-c-leo commented 10 years ago

The logo on first popup also doesn't appear.

diracdeltas commented 10 years ago

Is that on both icecat 24 and firefox 29?

salut-c-leo commented 10 years ago

Yes,on both.

salut-c-leo commented 10 years ago

And even Aurora 30 (the experimental version of Firefox).

ghost commented 10 years ago

I am using firefox 29 and the icon doesn't show for me either it is in my add ons list .

diracdeltas commented 10 years ago

@mrtino @BigAl49 what operating systems are you using? do you have any other addons installed?

opsydev commented 10 years ago

I can confirm the issue with Firefox 29 on Mac OSX 10.9 as well.

diracdeltas commented 10 years ago

FYI, Garrett and I tested this out quite a bit on Debian/Ubuntu with Firefox 29, Firefox Beta, Firefox ESR, and Firefox Aurora. So it's not broken in the general case, which makes me think it might have to do with unusual browser settings/themes and other extensions installed.

ghost commented 10 years ago

I am using windows 7 addons i have installed are adblock plus, better ttv, down them all, facebook purity, greasemonkey, last pass, personas plus, garmin comunicator.

diracdeltas commented 10 years ago

@BigAl49 can you try starting a new Firefox profile and installing only Privacy Badger to see if it shows up? Instructions on how to create a new profile are at https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles#w_starting-the-profile-manager

Thanks!

ghost commented 10 years ago

i just tried disabling all my addons one by one and just found that when i disabled last pass the icon is now showing.

diracdeltas commented 10 years ago

Ok, that helps a lot! Maybe the addon bar just doesn't have enough space for everything.

ghost commented 10 years ago

i will try putting back another add on to see what happens

opsydev commented 10 years ago

Disabling addons on OS X doesn't help. I tried creating a new profile with the Privacy Badger and it still didn't show up. In FF29, it doesn't even show up in the customize panel.

ghost commented 10 years ago

i added six more addons and the icon is still visible and i enabled last pass again and its still visible so i don`t know what happend but its working now.

t3kk commented 10 years ago

This is still an issue for Firefox 29 on mobile. It says it is not compatible with Firefox 29.

neverumind commented 10 years ago

No icon in FF 29 on Windows 8.1 32bit, w Update (KB2919355) et al. Nosquint 2.1.9 ABP 2.6 Disable all addon, cycled FF, even disable my custom windows DPI for 140% down to Default. No icon..

neverumind commented 10 years ago

Created new profile as suggested (Badger), installed PB and good to go. Installed Nosquint ditto. Installed ABP ditto all good.
Go to FF>Options>enable 'Never remember History' kills PB, or Custom to enable 'Private Browsing' kills PB. I will bookmark this hub and uninstall till I can run/test this with my preferred FF settings. Thanks

salut-c-leo commented 10 years ago

I tested Privacy Badger on Xubuntu 14.04 with GNU Icecat 24 and Firefox Aurora 30. I also tried with TenFourFox 24 (a fork of Firefox for PowerPC Macintosh on Mac OS X 10.4 Tiger) and nothing appeared expect on add-ons.

Migas7 commented 10 years ago

I have to appologise, because I reopen a already closed ticket/bug before seeing this one! I confirm that in Ubuntu Gnome 14.04 64 bits, the icon doesn't appear/show. UNLESS, in privacy tab on preferences the option "Never remember history" is not choosen/on. So, by not having that option on, the icon appears/shows. Therefore, I ask, what to do, to mantain both options?

neverumind commented 10 years ago

This may be off topic I don't know if this will help to isolate the situation, yet in Firefox 29.0 when all is working, specifically Privacy Browser w/icon (having your privacy options set to anything other than 'Never remember History', and 'Use Private Browsing') and a uses goes to Customize the toolbar; there is a text readout of where the Privacy Browser icon is located.

Tested using (Badger) profile with Privacy Browser working and Firefox settings set to Custom: Tracking: Do not tell sites anything about my tracking preferences (default) History: Use Custom Settings for history Accept cookies from sites Accept third-party cookies: Always Keep until: I close Firefox Clear history when Firefox closes

This is just a heads up that the Privacy Badger Icon is replaced by text "Privacy Badger" in a customize window and returns to the icon once the customize window is closed.

garrettr commented 10 years ago

Changed title to reflect that this is specifically about not seeing the icon after installation. We were getting mis-filed bugs elsewhere that were really dupes of this.

diracdeltas commented 10 years ago

Hi everyone, please check if your problems are still happening in the latest version: https://www.eff.org/files/privacy-badger-0.1.2.xpi

opsydev commented 10 years ago

It's fixed for FF29 on OS X.

Thank you!

neverumind commented 10 years ago

Total train wreak in FF 29.0 in Windows 8.1 w/Update. Once I installed the xpi, I could not visit this page without having cookies enable, trying to put myself back on 'Never Remember History' caused my Firefox to linger once closed in task manager. Two reboots later attempting to get my PRIVACY setting back to my preferences without success, I attempted the Firefox Help>Troubleshooting Information>Reset Firefox, which failed to reset cause FF was not ending without a full on "End Task".
Saved my json bookmarks, downloaded a fresh copy, uninstalled FF (all profiles), Ccleaner with a Reg clean, A reboot for a fresh install. Grabbed my ABP, and NoSquint, changed my PRIVACY setting to my liking and here I am to tattle on that xpi.

No Bueno!

neverumind commented 10 years ago

Did I leave out no icon either.
Yep! No Icon in Windows 8.1 w/Update and a train wreak.

salut-c-leo commented 10 years ago

The icon only appears with history activated. Because I only use "Never remember history", I will wait for Privacy Badger enabled on this history mode.

diracdeltas commented 10 years ago

@mrtino That's related to #11

garrettr commented 10 years ago

@neverumind Are you using the "Never remember history" setting?

neverumind commented 10 years ago

@garrettr Yes, TLDR....follows That is my preferred settings. And when the latest xpi did not work I attempted to post here and got past the logon to be told that 'Cookies must be enabled to use GitHub. I attempted to attempt .. that's right, attempted to attempt other setting to see just where the break point was. Yet I ran into a situation where modifying the privacy settings after the install of PB 0.1.2 would not save.. Attempting to set FF to Private browsing w/ 0.1.2 PB installed and not working and then disable, and then uninstalled (in all those instances, cause FF to never do a clean close, needing an "End Task" to close). This resulted in my Privacy setting never actually saving.

So this version is no different (excluding the havoc) to me than the other version, whereby on a Windows 8.1 OS, w/ FF 29.0 using PB v 0.1.1, if 'Remember history' is enabled all is well as I stated 4 days ago. I had not seen #11 till today.

Migas7 commented 10 years ago

Hi, I confirm, after installed PB 0.1.2 on Firefox 29 and 32 (nightly) on Ubuntu Gnome 14.04 64 bits, the problem persist. No icon on both Firefox. I use the set "Never remember history", and I'll continue to use it! So, is there a chance for you to make "everything" works with this setting on?

salut-c-leo commented 10 years ago

@Migas7 Like you, I use the set "Never remember history". I'll use Privacy Badger only when the addon will work on this setting.

Migas7 commented 10 years ago

Hi @mrtino, this issue was open 6 days ago, I install PB 4 days ago, a new version was released three days ago, and the problem still persist! I think that EFF is doing a very good job helping us all having a more secure and private web! That said, why is the last post from anyone of the developers two days old? Nothing to say abou this issue? At least writing about the fact that you are working on a solution, but you haven't found it yet! I'm going to unistall/remove the add-on and I'll came back in a month or so to see if there is ANY UPDATE!

diracdeltas commented 10 years ago

@Migas7 If your issue is that Privacy Badger doesn't work with "Don't remember history", it's a duplicate of #11 (incognito windows are basically the same as that setting). We're working on it, but it's not an easy issue to fix, so it will be at least a week before I can get a release out.

I'm going to close this issue because the toolbar icon was fixed, and it seems like everyone else here is experiencing #11. If there's a different bug, please open a new issue.

Migas7 commented 10 years ago

Well @diracdeltas you do have the power to close this issue! But the toolbar icon issue (as you call it!) is not fixed!!! I have, both 29 and 32 (nightly!) and I don't see ANY ICON of the PB on the toolbar! And I do have it on my Add-ons! And it's because I have set "Never Remember History" on my preferences, that the icon doesn't show. I've try it with a different setting and the icon was visible. If you say that now I have to report this issue to https://github.com/EFForg/privacybadgerfirefox/issues/11, then I will not!!! Because in my opinion, wich is different than yours, the issue still exists and this his the right place to report it! You just have to read the title of this issue to know that I'm right: No PB icon in toolbar on GNU Icecat 24 and Firefox 29

So close the issue! I've seen this type of action by developers all over the web! When a person becames to insisting about an issue, and you don't have a answer to it, you simply descart it (the issue) and her (the person). Because of your prepotent arrogance, you just lost a user! But what is one user? Right?! Goodbye.

diracdeltas commented 10 years ago

It's not clear that you understand why this issue was closed:

And it's because I have set "Never Remember History" on my preferences, that the icon doesn't show.

It doesn't show up because Privacy Badger isn't active if you set Never Remember History, same as for Incognito mode (which is #11). This was a deliberate decision for the alpha release, because Privacy Badger remembers some state that could be considered "History" (it needs to keep a count, internally, of some sites that you've visited in order to make decisions about what to block). So if you set "Never Remember History", we have three choices:

  1. We can operate anyways, which arguably violates the user's choice to not remember any history.
  2. We can not operate at all - this is the option that fully respects their choice to ignore all browsing history.
  3. We can figure out a way to operate and yet still respect user preferences, perhaps with some sort of warning in the UI when Privacy Badger turns on.

We currently do 2 but are hoping to do 3.

diracdeltas commented 10 years ago

(I closed this as a duplicate of #11 because when that issue is fixed, this one will be as well automatically. Confusingly, Firefox treats "incognito" mode similarly to regular mode with "never remember history" set.)

Migas7 commented 10 years ago

@diracdeltas , well, please explain two things to me if you can and want! First, what does that have to do with closing the issue, if the icon still isn't shown in the toolbar? Regardeless of the reason for the why? Which, I think, was the reason for opening this issue in the first place? So, in my opinion, only when it's solved (which is not!), should you decide to close it. Second, not remember history, is not and can never be considered the same as private browsing! Because, giving an example, if I acess my gmail account, log in and out, close the tab, when I reopen it again in a new tab, it only will ask me for my password and not for my email. So, the history/cookies, are stil there. They were not deleted when the tab was closed!! Only when I close Firefox and reopen it, will Google ask me for both my email and password. In the private browsing setting, this doesn't hapen. When you close a tab, all history is immediatly deleted!

The point beeing, this issue is NOT solved! Once again, our opinions are not the same! The ball is in your court now.

EDIT: Sorry, there are three things: Third, isn't PB similar in behaviour to the Add-on Disconnect (I'm sure you know it!)? Because if they are similar in behaviour, I have it installed, and working with no issues! The icon is shown, it blocks adds, etc and all this with the setting "Never Remember History" enable.

diracdeltas commented 10 years ago

@Migas7 This issue was closed because it appears to be a duplicate of #11; the root cause is the same. I could open it and mark it as "duplicate" if there are sufficient advantages to doing so.

Alpha software (especially the kind that was written by someone working part-time over the course of about 2 months) is bound to have bugs, not all of which will get fixed immediately. Thanks for testing.

Also, I have opened this bug with Mozilla, which should make things less confusing in the future: https://bugzilla.mozilla.org/show_bug.cgi?id=1009194

neverumind commented 10 years ago

@Migas7 Thank you for efforts in this new addon. I did notice that #11 became "urgent" within the past week and see it is mile-stoned for ~ 2.0. @diracdeltas Keep up the dedicated work. I for one can watch the root to see what others are experiencing as I have no further input until this work in progress supports/respects 'incognito, Never Remember History, and/or Private Browsing.

diracdeltas commented 10 years ago

@neverumind Thanks. The milestone on #11 should actually be the next release (0.1.4?) after the one today.