search

EFForg / privacybadgerfirefox-legacy

LEGACY Privacy Badger for Firefox SEE README
https://www.eff.org/privacybadger
Other
407 stars 68 forks source link

Setting to disable the first run page #698

Closed allo- closed 8 years ago

allo- commented 8 years ago

I am creating a profile generator for firefox, which preconfigures the profile for privacy https://github.com/allo-/firefox-profilemaker and would like to include privacy badger. To avoid having a dozen of first-run pages in the generated profile, i would like to have the possiblity to disable the page on privacy badger. I currently tried to copy this setting into the profile:

user_pref("extensions.jid1-MnnxcxisBPnSXQ@jetpack.sdk.load.reason", "startup");

But the installation seems to set it automatically to "install" and then show the privacy badger first run page.

By the way, the settings and id in the manifest seem to differ in the source and in the AMO version, the AMO version sets the @jetpack settings, while the defaults in the source have privacybadger there.

cooperq commented 8 years ago

I would happily accept a patch for this but it is not something that I have time to work on, sorry.

allo- commented 8 years ago

As far as i see, the loadReason is set by the SDK. Would you mind having another setting "firststartPageShown" or something similiar in addtion?

I can try to look into accessing a setting which does not need to be present for normal usage, but i am not sure if you can do so with the new extension SDK. My last firefox extension is some time ago ;-).

cooperq commented 8 years ago

having such a setting would be fine (though you should note that soon this codebase will be deprecated and we will be using the web extensions API).

allo- commented 8 years ago

This pullrequest should do. I am not sure about the settingname and how/why the build.sh script replaces "privacybadger" with an cryptic ID. Maybe the name of the setting needs to be adapted to this.

allo- commented 8 years ago

Any comment? Is there a reason, you're not merging it?

cooperq commented 8 years ago

Sorry, I haven't had time to merge pull requests for a while. It is now merged. Thanks for the commit!