search

EFForg / privacybadgerfirefox-legacy

LEGACY Privacy Badger for Firefox SEE README
https://www.eff.org/privacybadger
Other
407 stars 68 forks source link

Does not display change of the blocking state #730

Open rugk opened 8 years ago

rugk commented 8 years ago

See this gif:

As you can see I changed this state manually once, but currently PB does not care in any way how I change this. However when looking at this on the settings page it seems to have changed:

So now I don't even know whether it is blocked or not... BTW when changing the state on the options page it does also not shows the new state...

Privacy Badger 1.0.5 FF 44.0.2

cooperq commented 8 years ago

Yep, thats a bug alright. Do you see any errors in the privacy badger console or browser console? I am unable to reproduce this bug with the same version of privacy badger and ff

rugk commented 8 years ago

Do you see any errors in the privacy badger console or browser console?

  1. There is a PB console??
  2. No, there are no errors in the browser console.
cooperq commented 8 years ago

There is a PB console indeed! If you enable addon debugging you can click the debug button for privacy badger in about:addons and get a console. The same debugging messages should show up in the browser console though.

So, I am curious if this bug is related to issue #711 - are you able to reproduce this in a clean firefox profile with a new install of privacy badger? Let me know when you have addon debugging set up, and I will ask for some more information.

rugk commented 8 years ago

Okay, so I found the culprit: It is again CanvasBlocker. With it activated the options page reloads when I try to change the sliders.

And yes I've set up addon debugging.

BTW I don't think this issues are related.

cooperq commented 8 years ago

I am also unable to reproduce this issue still even with a fresh profile with just canvas blocker and privacy badger. Are you able to reproduce it with a fresh profile?

rugk commented 8 years ago

githubtest-gif.zip

This is the same gif as in https://github.com/EFForg/privacybadgerfirefox/issues/711, but at the end you can also see this issue happening. I discovered that it only happens when you use Ctrl+F to look (e.g.) for google. If you use PrivacyBadger's built-in search function this does not happen.

cooperq commented 8 years ago

Can you please give me exact steps to reproduce this on a fresh profile?

rugk commented 8 years ago

😟

Okay... once again.

  1. Make sure you e.g. have ssl.google-analytics.com in your block list.
  2. Go to the settings page of PB.
  3. Use Ctrl+F to search for google
  4. Click on the slider of the found entry.

You'll see that the whole settings page reloads and it does not change the setting (or only does so on the second click).

cooperq commented 8 years ago

Thank you! I can finally reproduce this, and it looks like it is fixed in the current master of privacy badger. So you should see the fix when the next release comes out.