search

EFForg / privacybadgerfirefox-legacy

LEGACY Privacy Badger for Firefox SEE README
https://www.eff.org/privacybadger
Other
407 stars 68 forks source link

Refactor domain search on options page #745

Closed rcutmore closed 8 years ago

rcutmore commented 8 years ago

This should hopefully help with the delay while typing in the domain search input on the options page when there are a lot of tracking domains. As the user types it stores the search text, waits half a second, and checks to see if the search text has changed. If so it avoids filtering, otherwise it proceeds.

I also fixed a bug introduced with the page refresh changes.

cooperq commented 8 years ago

This change looks good. There is still an annoying behavior where we refresh the page when someone changes the setting for a domain, which causes the search result to be reset, but I think that can be fixed separately.

rcutmore commented 8 years ago

I think the page is being refreshed when any setting is changed. The same thing happens if you add/remove a domain on the Whitelisted Domains tab.

I'll take a look. During a refresh we should be able to update the displayed domains differently depending on whether or not any search text has been entered.