EFForg / privacybadgerfirefox-legacy

LEGACY Privacy Badger for Firefox SEE README
https://www.eff.org/privacybadger
Other
407 stars 68 forks source link

False negatives reported for late-loading widgets on continuous-scroll websites. #790

Open jberkus opened 8 years ago

jberkus commented 8 years ago

Example of issue:

  1. Go to pydx.org.
  2. Click "register" top menu
  3. Scrolls down to registration section
  4. 3rd-party registration widget does not load
  5. privacy badger is reporting "Nothing blocked for this site"
  6. reload page
  7. click registration again
  8. now PB shows that the ti.to domain for the registration widget is blocked.

What appears to be happening is that, if a 3rd-party widget for a long, continous scroll page is loaded "just in time", PB blocks the widget but doesn't update its block-list UI. This makes the user think that the problem with the web page is something else entirely, and also prevents them from unblocking it without a reload.

cooperq commented 8 years ago

I am halting all development on this version of privacy badger in favor of getting a web extension compatible version out. This will share the same codebase with https://github.com/efforg/privacybadgerchrome . Is your issue reproducable with the chrome version of privacy badger?

jberkus commented 8 years ago

I don't know, I don't use Chrome much.