Does not show trackers on the current page in FF48

yumashka commented 8 years ago

After updating to Firefox 48:

When entering any page Privacy Bager shows icon with non-zero counter indicating that it has blocked some trackers. It really does according to how pages are looking (almost no ads)
But after clicking on icon it shows no trackers and says that it "detected 0 potential trackers on this page" however counter is still non-zero

Tested on two old installations and one fresh FF+PB installation

pb-counter

onderzoekspraktijk commented 8 years ago

+1

haesemeyer commented 8 years ago

Exactly same issue here after update to FF48 (Mac OSX). In fact, the usual sliders briefly flash up after clicking on the toolbar icon and then vanish changing to a screen as in the screenshot above.

Below a poorly formatted stack trace:

`privacybadger:TypeError: action.contains is not a function Stack trace: refreshPopup@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/loader/sandbox.js -> resource://jid1-mnnxcxisbpnsxq-at-jetpack/data/popup.js:232:11 @resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/loader/sandbox.js -> resource://jid1-mnnxcxisbpnsxq-at-jetpack/data/popup.js:472:3 onEvent@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/loader/sandbox.js -> resource://gre/modules/commonjs/sdk/content/content-worker.js:45:22 onEvent@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/loader/sandbox.js -> resource://gre/modules/commonjs/sdk/content/content-worker.js:45:22 onChromeEvent@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/loader/sandbox.js -> resource://gre/modules/commonjs/sdk/content/content-worker.js:91:16 timers.js:43

privacybadger:TypeError: tab is undefined Stack trace: getTabId@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/tabs/utils.js:206:1 Tab<.id@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/tabs/tab-firefox.js:75:44 getWindowForSdkTab@resource://gre/modules/commonjs/toolkit/loader.js -> resource://jid1-mnnxcxisbpnsxq-at-jetpack/lib/utils.js:149:1 exports.getSocialWidgetContentScriptData@resource://gre/modules/commonjs/toolkit/loader.js -> resource://jid1-mnnxcxisbpnsxq-at-jetpack/lib/socialWidgetHandler.js:57:14 enable/</<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://jid1-mnnxcxisbpnsxq-at-jetpack/lib/main.js:275:11 emitOnObject@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:112:9 emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:89:38 receive@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/content/worker.js:74:26 emitOnObject@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:112:9 emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:89:38 emitOnObject@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:112:9 emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:89:38 emitOnObject@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:123:45 emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:89:38 messageReceived@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/remote/parent.js:96:37`

jbwCode commented 8 years ago

I also have experienced this issue with symptoms as described by the original poster, yumashka. I have been using Privacy Badger for months on several systems and it has been working just fine,

But since upgrading to Firefox 48 on my Windows 10 Pro x64 PC this issue has started.

I have tried starting Firefox 48 with a clean test profile including Privacy Badger as the only extension. No improvement shown.

I tested with Xubuntu 16.04 x64 VM running Firefox 47. No issues with Privacy Badger. So I upgraded it to Firefox 48, and then the issue started.

I tested on a windows XP x86 VM running Firefox 30-something, and Privacy Badger was fine. So I upgraded to Firefox 48, and same issue started again.

So it is my conclusion that something has changed in Firefox 48 for multiple platforms, that is now breaking Privacy Badger.

oneofthedamons commented 8 years ago

+1 for Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:48.0) Gecko/20100101 Firefox/48.0

chekavy commented 8 years ago

The same issue in Firefox 48 on Fedora 24.

squaregoldfish commented 8 years ago

I have slightly different behaviour to @haesemeyer - I don't see the trackers, but I briefly see a 'Loading...' message which then disappears.

(Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:48.0) Gecko/20100101 Firefox/48.0)

sathood commented 8 years ago

same problem encountered for the last few days.

noted something else, PB isn't picking up any new trackers.

so, it appears to be blocking existing trackers that have been limited/blocked, but ability to control newly encountered trackers has been disabled ; (

markrrr commented 8 years ago

same problem in FF48 under Linux Mint 17.3

ghost commented 8 years ago

This will probably be fixed by EFForg/privacybadgerchrome#845 Will this fix Firefox V48? Also dose EFF know about this issue?

cooperq commented 8 years ago

EFF Developer here. For all of you I need to know, do you have multiprocess firefox (E10S) Enabled? You can check in settings. If you do, does privacy badger work again if you disable multiprocess firefox?

haesemeyer commented 8 years ago

Multiprocess windows (as shown by about:support) is disabled on my firefox.

cooperq commented 8 years ago

okay this was apparently not a multiprocess problem. I found the fix for this and I will release a new version today.

ghost commented 8 years ago

I use FF v48 looked for it when I typed about:supprt and found this. "Multiprocess Windows 0/2 (Disabled)". I just saw you will release a new vertion today. How will I get that and how will I know I got it?

cooperq commented 8 years ago

@b1teman it will auto update. You will know you got it because privacy badger will work again!

cooperq commented 8 years ago

the fixed version will be 1.8.0

ghost commented 8 years ago

I use FF v48 looked for it when I typed about:supprt and found this. "Multiprocess Windows 0/2 (Disabled)". I just saw you will release a new vertion today. How will I get that and how will I know I got it?

ghost commented 8 years ago

The update will come thru the update function in my Add-ons Manager section in FF v48?

cooperq commented 8 years ago

Correct.

On August 8, 2016 2:08:57 PM PDT, b1teman notifications@github.com wrote:

The update will come thru the update function in my Add-ons Manager section in FF v48?

You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/EFForg/privacybadgerfirefox/issues/792#issuecomment-238378129

Sent from my Android device with K-9 Mail. Please excuse my brevity.

ghost commented 8 years ago

Thanks I downloaded the new version this morning from your site. It would not update thru FF Add-ons page. Is that something that will happen for all the other FF users?

Thank you for the quick update. So far it is working the way it use to. So Thanks again.

haesemeyer commented 8 years ago

For me it updates just fine through firefox and the problems seem to be fixed!

Thanks for the quick action.

oneofthedamons commented 8 years ago

Confirmed fixed for my Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:48.0) Gecko/20100101 Firefox/48.0 – thanks – but your changelog for 1.8.0 in https://addons.mozilla.org/en-US/firefox/addon/privacy-badger-firefox/ says "fixes breaking bug in firefox 38" when I think you mean firefox 48 :-)

neonriots commented 8 years ago

Woohoo, PB works again. Thanks, devs. = )

jramnani commented 8 years ago

If you're impatient and don't want to wait for Firefox's Auto Update to kick in, you can turn off Automatic Updates in the Privacy Badger preferences, and a "Check for Update" button will appear. You can click that to get an update sooner. Just don't forget to re-enable Auto Updates when you're done.

Confirmed version 1.8.0 works for me.

Firefox 48.0 OS X 10.11.6

jbwCode commented 8 years ago

All good here again with PB version 1.8.0. Thanks for the quick fix!!!

Used the Firefox "Check for Updates" command in the Add-ons manager tools drop-down.

Firefox 48.0 Windows 10 Pro version 1511, OS Build 10586.494 Xubuntu 16.04.1 LTS Linux Mint 7.3 Cinnamon

yumashka commented 8 years ago

I also confirmed version 1.8.0 works for me: Firefox 48.0 / Win7x64

yumashka commented 8 years ago

Oops! Sorry, close issue too fast. Need to reopen it. Not all UI elements are shown correctly: (only on Russian) pb180

PS. How to change PB language? I have two Win7x64RUS computers: home and work. At work PB is English, at home PB is Russian. FF language settings are the same.

cooperq commented 8 years ago

That is a separate issue, please open a new issue.

EFForg / privacybadgerfirefox-legacy

Does not show trackers on the current page in FF48 #792