EFForg / starttls-frontend

Static front end for the STARTTLS scanner
Other
6 stars 3 forks source link

Remove local part of email from domain field #287

Closed rubicae closed 4 years ago

rubicae commented 4 years ago

Remove everything up to and including the @ symbol in the domain input box when it loses focus. This should let users enter email addresses and have them converted to domain names, addressing #249

sydneyli commented 4 years ago

Thanks @rubicae! Generally LGTM. One small nit/question: why trim the domain name when the field loses focus rather than on submit?

rubicae commented 4 years ago

I considered three possibilities for when to trim the email down to just the domain:

I thought changing it as the user was typing would be too jarring, particularly if they're entering it by hand. Doing it when the input loses focus would hopefully be less jarring and still give the opportunity for the user to see the change if they continue moving around the page (e.g. click elsewhere or tab to the next part of the form). Having it do this in on submit entirely hides the process from the user so they have no way of seeing the change.

I'm not particularly attached to doing it this way or sure that this is the best way and would be happy to do something else if you think a different one of these or a totally different solution is better.

m0namon commented 4 years ago

OK! That makes sense to me. Last thing is, would you mind also updating this text: https://github.com/EFForg/starttls-frontend/blob/87646c1ed57c2e8c0e6397616b5a3066a5532466/layouts/partials/no-mxs.html#L3

Now that this is done, we can probably remove the last two sentences in the message.

rubicae commented 4 years ago

I have now removed the no longer relevant text!