Closed ApolloZhu closed 3 years ago
Merging #109 (8453bc7) into main (eaaf55e) will increase coverage by
2.70%
. The diff coverage is59.78%
.
@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 58.80% 61.50% +2.70%
==========================================
Files 14 15 +1
Lines 869 982 +113
==========================================
+ Hits 511 604 +93
- Misses 358 378 +20
Impacted Files | Coverage Δ | |
---|---|---|
Source/CIColor+.swift | 100.00% <ø> (ø) |
|
Source/NSColor+.swift | 25.00% <0.00%> (+2.77%) |
:arrow_up: |
Source/NSImage+.swift | 50.00% <ø> (ø) |
|
Source/EFIntSize.swift | 62.50% <25.00%> (ø) |
|
Source/EFQRCode+Migration-v6.swift | 45.58% <45.58%> (ø) |
|
Source/EFQRCode+GIF.swift | 28.57% <50.00%> (+28.57%) |
:arrow_up: |
Source/EFQRCode.swift | 53.57% <51.85%> (ø) |
|
Source/EFQRCodeGenerator.swift | 77.89% <66.66%> (+1.19%) |
:arrow_up: |
Source/EFQRCode+ObjC.swift | 71.42% <71.42%> (ø) |
|
Source/EFQRCodeRecognizer.swift | 82.35% <87.50%> (+24.45%) |
:arrow_up: |
... and 4 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update eaaf55e...8453bc7. Read the comment docs.
Finals week, probably get back to this during winter break
Examples of the new API:
EFQRCodeMode.none
toEFQRCodeMode?.none
, i.e.nil
EFQRCodeGenerator.with<T>(_: ReferenceWritableKeyPath<Self, T>, _: T) -> Self
to set property directly and chain invocationsEFQRCode+Migration-v6.swift
) aredeprecated
, and should be marked asobsoleted
/unavailable
with v7 release, and the file completely deleted with v8 release.EFQRCodeGenerator
,EFQRCodeRecognizer
are now equally available in Swift/ObjC, andEFQRCode
will be Swift onlyEFUIntPixel
appears to be not an active part of the existing public API, so it will no longer bepathToSave
from GIF generation API