search

EFPrefix / EFQRCode

A better way to operate QR Code in Swift, support iOS, macOS, watchOS and tvOS.
https://efprefix.github.io/EFQRCode
MIT License
4.57k stars 481 forks source link

Circleci project setup #124

Closed justshane21 closed 3 years ago

ApolloZhu commented 3 years ago

Hi @justshane21, welcome and congrats on making your first pull request! Here are a few things that we'd like you to do/clarify:

  1. Your edits seems to be based on the outdated master branch. Please make changes to main branch instead.
  2. Your CircleCI config seems to be for Python, but EFQRCode is a Swift project. Are you sure this configuration file is correct?
  3. We are currently not using CircleCI for automation. Could you please elaborate on why this change is a good addition to this project?
ApolloZhu commented 3 years ago

Closing this pull request due to inactivity. But feel free to submit another one after addressing the questions above 🤝