ClientID

[Roemke]

Hello, thanks for your work. I have two topics.

The ClientID ist generated allways as Random-Value. I need a fixed value and solved as follows: In the Header-File: ESPPubSubClientWrapper(uint8_t *ipaddr, const char * clientID, uint16_t port = 1883); and in cpp: ESPPubSubClientWrapper::ESPPubSubClientWrapper(uint8_t* ipaddr, const char * clientID, uint16_t port) :PubSubClient(ipaddr, port, _wiFiClient) { _clientID = (char *) clientID; }; This works in my case, I connect only without authentification.

Furthermore I found a method doSetConnect(). In this method there is used the member _connect_id. It seems to me, that this member is never used again.

Greetings Karsten

[EFWob]

Hi Karsten,

thank you for finding the bug. I would like to keep the API as is and therefore apply the following fix:

• The member _clientID is obsolete and shall not be used, therefore removed from the class definition.
• Instead, _connect_id must be used. As you pointed out, this is set in the member function doSetConnect() This function is a protected function hence cannot be called from the user application direct but is used by the various connect(...) member functions.
• Any member function connect() allows to define the client-ID, in it simplest form just as connect("MySpecificClientID")
• For the settings in connect() to take effect, connect() must be called BEFORE the first ever call to the loop() member function. So calling client.connect() (somewhere) in setup() and client.loop() within the main-loop() should to the trick.
• The final fix is to replace the access to _clientID in the definition of ::loop() by an access to __connectid

I have done the fix and put it under the branch "ConnectFix". I still need to update Readme and examples later (before merging into main), but may be you can give it a try already. Works for me...

Best

Erik