search

EFeru / DbcParser

.NET CAN bus dbc file parser
MIT License
76 stars 28 forks source link

Signal.Length >255 #18

Closed taylorjdlee closed 1 year ago

taylorjdlee commented 1 year ago

17 Is still not fixed both line 64 and 97 in SignalLineParser.cs need to be changed to ushort.Parse instead of byte.Parse

https://github.com/EFeru/DbcParser/blob/aa1a163ddda16367dfc6b3ca0f698a2bd2fb4c6a/DbcParserLib/Parsers/SignalLineParser.cs#L64

https://github.com/EFeru/DbcParser/blob/aa1a163ddda16367dfc6b3ca0f698a2bd2fb4c6a/DbcParserLib/Parsers/SignalLineParser.cs#L97

taylorjdlee commented 1 year ago

Hi @EFeru wonder if you could approve this PR as I'm currently waiting on it thanks!

EFeru commented 1 year ago

Hi @taylorjdlee . Sorry i missed your PR, i just saw it now. It is merged. Thank you very much for you contribution!