search

EGA-archive / LocalEGA

A federated storage for sensitive data
http://localega.readthedocs.io
Apache License 2.0
7 stars 16 forks source link

Fix unclosed socket warning #102

Closed silverdaz closed 6 months ago

silverdaz commented 4 years ago

When the message broker is not yet on, and the pipeline services try to contact it, they issue a unclosed socket warnings. See ampq.py

Expected Behavior

Close the socket properly if open and cannot connect.

Current Behavior

Issues a warning. I'm afraid it's wasting sockets (at the level of the OS). Hopefully, it's a minor issue, cuz the (wasted) sockets will timeout and the OS will reclaim them.

Possible solution

Review the code by someone else with competence in socket in python (and/or OS).

silverdaz commented 6 months ago

This issue can probably be closed given the new version ? What do you say, @sdelatorrep ?

silverdaz commented 6 months ago

Closing it, since it doesn't happen in the updated version