search

EGA-archive / LocalEGA

A federated storage for sensitive data
http://localega.readthedocs.io
Apache License 2.0
7 stars 16 forks source link

Feature/external images #44

Closed silverdaz closed 5 years ago

silverdaz commented 5 years ago

Externalizing the MQ, DB and Inbox images

Describe the pull request:

Pull request long description:

The bootstrap and docker-compose now pull images from external repos for DB, MQ and Inbox.

Bootstrap uses latest, deployments should use stable (or equivalent).

dtitov commented 5 years ago

Not sure if I have to put this comment here or in https://github.com/EGA-archive/LocalEGA-mq repo, but why not use static shovels instead of dynamic? At least it will eliminate the need for sleeping during initialization. And, to me, it is much more straight-forward and neat solution.

silverdaz commented 5 years ago

I'd say, create an issue in LocalEGA-mq. and....yes... go ahead and write the Erlang code for it.

dtitov commented 5 years ago

Ok, I'll create a suggestion issue there then. And I already did the similar implementation of static shovels: https://github.com/uio-bmi/localega-broker/blob/master/public/advanced.config It's not that complicated :)

silverdaz commented 5 years ago

I forgot something. Closing temporarily to avoid confusion. Re-opening soon.

silverdaz commented 5 years ago

MQ user/password/password_hash are now generated. guest:guest is not hard-coded. See the trace file for the local broker credentials.

blankdots commented 5 years ago

Running tests in parallel seems to bring between 3-5 minute improvement in speed, and as we are not automating anything, I would recommend keeping the stages separated and first work on improving the speed of our review process.

silverdaz commented 5 years ago

Running tests in parallel seems to bring between 3-5 minute improvement in speed,

Good!

and as we are not automating anything, I would recommend keeping the stages separated and first on improving the speed of our review process.

I'm not understanding this sentence.

silverdaz commented 5 years ago

You managed to measure the difference? Thanks!

A 3 min improvment for the same correctness level.... I'll take it anytime.