search

EGA-archive / beacon2-ri-api

Beacon v2 Reference Implementation (API)
Apache License 2.0
16 stars 38 forks source link

React app credentials #272

Closed nicodr97 closed 7 months ago

nicodr97 commented 7 months ago

Hi,

In the Instructions on how to deploy the Beacon User Interface you explain how to modify the credentials for the React app and you mention that they will not be copied to GitHub for security reasons. However you have a .env file with those credentials values in your repository. I guess you first uploaded it before adding .env to .gitignore file.

Cheers, Nicolás

costero-e commented 7 months ago

Hi @nicodr97, and thanks for opening this issue.

Yes, you are right. We are showing now the file with these credentials because this is just a "test" environment for LifeScience and we just need some "testers" to be able to log in this environment.

Once we remove this "test" environment, those credentials will have no value.

Anyway, thanks for warning this, because at some point we will need to generate new secret values for this "test" environment and this has reminded me I have to do it.

Thank you.

Oriol