EGA-archive / beacon2-ri-api

Beacon v2 Reference Implementation (API)
Apache License 2.0
16 stars 38 forks source link

Issues with count response #312

Closed gsfk closed 5 months ago

gsfk commented 5 months ago

Looking again at the reference implementation after a break of a couple years, thanks for all your work. I had a couple issues with count responses:

costero-e commented 5 months ago

Hi @gsfk, it's a pleasure to have you here again. Thanks for your feedback. For the first question, I'm afraid that requested_granularity is not in the specs as a get request parameter:

paths:
  /individuals:
    get:
      parameters:
        - $ref: '#/components/parameters/requestedSchema'
        - $ref: '#/components/parameters/skip'
        - $ref: '#/components/parameters/limit'
        - $ref: '#/components/parameters/includeResultsetResponses'
        - $ref: '#/components/parameters/filters'

For the second issue you are commenting, you are absolutely right, I reviewed your PR and I will accept it now, thank you very much! Oriol

gsfk commented 5 months ago

Huh... I'm often surprised how far apart the GET and POST parts of the spec are.

Thanks for this!

costero-e commented 5 months ago

You are welcome!