search

EGA-archive / beacon2-ri-api

Beacon v2 Reference Implementation (API)
Apache License 2.0
16 stars 38 forks source link

docker-compose.yml Incompatibilities with B2RI documentation #327

Open NoeRzPz opened 3 months ago

NoeRzPz commented 3 months ago

Hi, on B2RI documentations there is an alert informing that the external tools are compiled for x86-64 architecture, but line 127 of docker-compose.yml use an image compiled for arm64 architecture. I would suggest commenting this line and uncommenting line 126. Also I would suggest to change container name in line 39, and use the same name as in B2RI documentation (mongo) Screenshot from 2024-05-19 10-02-58 as well as add - my-app-network to mongo-express container in line 66. Applying those changes would allow to change line 33 in beacon2-ri-tools/config.yaml for: mongodburi: mongodb://root:example@mongo:27017/beacon?authSource=admin and avoid problems when we are not working on a localhost (127.0.0.1). I hope these suggestions will be useful for a smoother implementation.

Best wishes, Noelia

costero-e commented 3 months ago

Hi @NoeRzPz, thanks for reporting this. We are currently working on a better documentation website, and as you spotted, the one you are showing is not updated. I hope the new one solves these conflicts. On the other hand, I have to tell you we have a new version of beacon ri tools, v2, which is the one we are mantaining at EGA. We will add the my-app-network to mongo-express container, anyway, if that helps. Thank you, Oriol

NoeRzPz commented 3 months ago

Thank you so much @costero-e !! Maybe you could add the new version of beacon ri tools, v2 repo to the B2RI documentation, because the section Download & Installation points toward this github repo Screenshot from 2024-05-22 11-29-24 I'm new at deploying it and I followed that documentation :-) Best wishes, Noelia

NoeRzPz commented 3 months ago

Sorry, I've seen that the new version of beacon repo you mentioned is only for the beacon2-ri-tools and doesn't include the beacon2-ri-api. The method 1 in B2RI Download & Installation section points to the right repo (ignore my previous issue). Maybe what could be updated then is the part regarding the beacon-ri-tools inside the api repo , so the beacon deployers could work with the new version. Many thanks!!

costero-e commented 3 months ago

Hi @NoeRzPz, yes, you are absolutely right. This is an issue that is pending to be done, but we have it open here #289. I hope to have this solved asap, sorry for the inconveniences!

Best, Oriol