EGA-archive / crypt4gh

GA4GH cryptographic tools
http://crypt4gh.readthedocs.io
Apache License 2.0
18 stars 12 forks source link

Cryptographic API Misuse Vulnerability #44

Open lialon opened 3 months ago

lialon commented 3 months ago

Description:

In the "crypt4gh/crypt4gh/keys/ssh.py", I have identified a security vulnerability about insecure cryptographic algorithm. Triple DES(TDEA) is disallowed or for legacy use after 2023.

Location:

https://github.com/EGA-archive/crypt4gh/blob/master/crypt4gh/keys/ssh.py#L70

return Cipher(algorithms.TripleDES(key), modes.CBC(iv), backend=backend)

Reference

Recommendations:

Try using other symmetric encryption algorithm like AES instead of TDEA.