EGI-Federation / cloud-info-provider

EGI Cloud Information System Provider

Apache License 2.0

3 stars 15 forks source link

Publishers: stdout and AMS #178

Closed enolfc closed 4 years ago

enolfc commented 4 years ago

Summary

This PR brings pluggable support for the output. 2 initial publishers are provided: stdout (the one we already had) and ams for pushing messages to ARGO AMS

enolfc commented 4 years ago

AMS support is broken in python3 :( Could just use requests instead, but need to check the actual API calls needed for that.

enolfc commented 4 years ago

Thanks, looks great! Could you please add some documentation before we merge this?

yes, will do in a subsequent commit

And what is the status of tests?

I'm now testing with the catch-all stuff, will check with AppDB if they are still getting the same information And some unit tests will be coming also to this repo

Last point, should we release a version before this is merged, or should we wait for it?

I think is better to wait, as I want ONE providers to use this directly

enolfc commented 4 years ago

I believe now it's ready, @gwarf take a look when you can