search

EGI-Federation / documentation

Sources to build EGI documentation site.
https://docs.egi.eu/
MIT License
13 stars 48 forks source link

Missing }; #541

Closed EGI-ILM closed 1 year ago

EGI-ILM commented 1 year ago

I have not read the code, just placed it according to the indentation. Please VERIFY that this is located in the right place.

gwarf commented 1 year ago

@enolfc , @andrea-manzi what do you think of this one?

andrea-manzi commented 1 year ago

can we deploy and see what is changing?

gwarf commented 1 year ago

can we deploy and see what is changing?

I've just enabled the preview. From my local tests, it seemed that the change I proposed was necessary to resolve warnings/errors from the dev tools. Didn't saw much changes in the UI, but wasn't sure what may be broken or not.

github-actions[bot] commented 1 year ago

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/541

thebe14 commented 1 year ago

Commit it with the }); added, I will start working on the documentation next week, will check that the category icon styles are properly applied in the sidebar. Also that keyboard navigation works.

github-actions[bot] commented 1 year ago

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/541

gwarf commented 1 year ago

OK, thanks Levente, will merge this once the tests are green, GitHub is having issues cf https://www.githubstatus.com/: Screenshot 2022-11-25 at 16 12 37

You purposely disabled linting those files in #244, but it may have caught this ;)