EGI-Federation / documentation

Sources to build EGI documentation site.

https://docs.egi.eu/

MIT License

13 stars 48 forks source link

[Check-in] Add section for the Logout Endpoint #549

Closed nikosev closed 1 year ago

nikosev commented 1 year ago

Summary

This PR introduces the following changes:

Add section for Logout Endpoint
Fix case of OIDC terminology
Update instruction of creating SAML SP metadata
Add section for Redirect URIs
Add section for UserInfo Endpoint
Add section for Introspection Endpoint
Fix notes refering to the endpoints table
Move flow descriptions from Endpoints to Grant Types section
Make duplicate headers unique in order to use them in links

github-actions[bot] commented 1 year ago

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/549

github-actions[bot] commented 1 year ago

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/549

github-actions[bot] commented 1 year ago

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/549

github-actions[bot] commented 1 year ago

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/549

github-actions[bot] commented 1 year ago

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/549

gwarf commented 1 year ago

@nikosev please confirm the changes I made are fine and I will merge, thanks!

github-actions[bot] commented 1 year ago

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/549

github-actions[bot] commented 1 year ago

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/549

github-actions[bot] commented 1 year ago

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/549

nikosev commented 1 year ago

Hi @gwarf ! I thought that the dollar sign ($) in front of the commands should be placed when the command is followed by the output of the command. Since the curl commands are now followed by their output, I didn't include the dollar sign. If we need to add the dollar sign to all commands, then I need to update all the commands in the SP guide.

Also, the indentation of all the curl commands is set to 2 spaces. Should I update it to 4 spaces?

gwarf commented 1 year ago

Hi, so yes, we agreed to use the prompt sign on all commands, to have a coherent usage. We have some info on https://docs.egi.eu/about/contributing/style/#basic-rules and https://docs.egi.eu/about/contributing/shortcodes/#code-or-shell-snippets.

So for the indentation of the commands, basically they should always be two spaces from the parent/reference. Here there was the need to increment them due to adding the $ prompt, so that the second line is properly padded.

github-actions[bot] commented 1 year ago