EGI-Federation / documentation

Sources to build EGI documentation site.
https://docs.egi.eu/
MIT License
13 stars 48 forks source link

Fix relative links in adhoc tutorials #600

Closed sebastian-luna-valero closed 1 year ago

sebastian-luna-valero commented 1 year ago

Summary

Strange that this wasn't picked up in https://github.com/EGI-Federation/documentation/pull/598


Related issue :

github-actions[bot] commented 1 year ago

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/600

gwarf commented 1 year ago

Strange that this wasn't picked up in #598

It's likely due to this setting: https://github.com/EGI-Federation/documentation/blob/main/.github/workflows/check-links.yml#L22-L26

Would probably be good to update it, as it's seems a quite idea to ensure that no changes on organisations are not breaking links. That said we should also be sure that all false positives are excluded (meaning as due to this we may still miss some broken links)

gwarf commented 1 year ago

If you want/have time we could use this PR to run this check on all files, and fix other issues. Otherwise it's for later...

github-actions[bot] commented 1 year ago

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/600

gwarf commented 1 year ago

@sebastian-luna-valero can you remove the link to https://wiki-igi.cnaf.infn.it/twiki/bin/view/CREAM/UserGuideEMI3 ? We still have another reference, and we will later just purge this.

github-actions[bot] commented 1 year ago

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/600

enolfc commented 1 year ago

If you want/have time we could use this PR to run this check on all files, and fix other issues. Otherwise it's for later...

I would merge now so we have this fixed. Then open a new one with fixing other broken links