EGI-Federation / documentation

Sources to build EGI documentation site.
https://docs.egi.eu/
MIT License
13 stars 46 forks source link

Use new TCS ACME GEANTOV ACME endpoint #660

Closed gwarf closed 2 weeks ago

gwarf commented 2 weeks ago

Use new TCS ACME GEANTOV ACME endpoint

github-actions[bot] commented 2 weeks ago

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

Unrecognized words (5)

csr hmac newkey rsa Unregistering

To accept these unrecognized words as correct, you could run the following commands ... in a clone of the [git@github.com:EGI-Federation/documentation.git](https://github.com/EGI-Federation/documentation.git) repository on the `gwarf-patch-tcs` branch ([:information_source: how do I use this?]( https://github.com/check-spelling/check-spelling/wiki/Accepting-Suggestions)): ``` sh curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' | perl - 'https://github.com/EGI-Federation/documentation/actions/runs/9487065181/attempts/1' ```

OR

To have the bot accept them for you, reply quoting the following line: @check-spelling-bot apply updates.

Available :books: dictionaries could cover words (expected and unrecognized) not in the :blue_book: dictionary This includes both **expected items** (21) from .github/actions/spelling/expect.txt and **unrecognized words** (5) Dictionary | Entries | Covers | Uniquely -|-|-|- [cspell:node/dict/node.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/node/dict/node.txt)|891|3|1| [cspell:php/dict/php.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/php/dict/php.txt)|1689|2|| [cspell:golang/dict/go.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/golang/dict/go.txt)|2099|2|| [cspell:aws/aws.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/aws/aws.txt)|218|1|| [cspell:python/src/python/python.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/python/src/python/python.txt)|392|1|| Consider adding them (in `.github/workflows/spelling.yml`) for `uses: check-spelling/check-spelling@main` in its `with`: ``` yml with: extra_dictionaries: cspell:node/dict/node.txt cspell:php/dict/php.txt cspell:golang/dict/go.txt cspell:aws/aws.txt cspell:python/src/python/python.txt ``` To stop checking additional dictionaries, add (in `.github/workflows/spelling.yml`) for `uses: check-spelling/check-spelling@main` in its `with`: ``` yml check_extra_dictionaries: '' ```
gwarf commented 2 weeks ago

To have the bot accept them for you, reply quoting the following line: @check-spelling-bot apply updates.

Let's see how it works

github-actions[bot] commented 2 weeks ago

:hourglass: check-spelling changes applied

As configured, the commit pushed by @check-spelling-bot to GitHub doesn't trigger GitHub workflows due to a limitation of the @github-actions system.

Users with the Admin role can address this for future interactions :magic_wand: #### Create a deploy key and secret ``` sh ( set -e brand=check-spelling; repo='EGI-Federation/documentation'; SECRET_NAME=CHECK_SPELLING cd "$(mktemp -d)" ssh-keygen -f "./$brand" -q -N "" -C "$brand key for $repo" gh repo deploy-key add "./$brand.pub" -R "$repo" -w -t "$brand-talk-to-bot" gh secret -R "$repo" set "$SECRET_NAME" < "./$brand" ) ``` #### Configure update job in workflow to use secret If the `.github/workflows/spelling.yml` workflow `Update PR` job doesn't already have the `check-spelling`/`with`/`ssh_key`, then add them: ``` diff name: Update PR ... steps: ... - name: apply spelling updates uses: ${action_ref:-check-spelling/check-spelling@...} with: checkout: true + ssh_key: "${{ secrets.CHECK_SPELLING }}" ```

To trigger another validation round and hopefully a :white_check_mark:, please add a blank line, e.g. to .github/actions/spelling/expect.txt and commit the change.

gwarf commented 2 weeks ago

So it seems that for some reason the CI/CD wasn't triggered/running, not sure if it's due to this special flow... In fact there is some stuff here: https://github.com/EGI-Federation/documentation/actions/runs/9495479440

gwarf commented 2 weeks ago

The Check-spelling job was skipped, so there is no reporting

github-actions[bot] commented 2 weeks ago

@check-spelling-bot: Could not perform request.

The referenced report comment is hidden (resolved). This probably means the changes have already been applied. Did you mean to apply the most recent report (https://github.com/EGI-Federation/documentation/pull/660#issuecomment-2164813153)?

See log for details.

gwarf commented 2 weeks ago

I will just force the merge, not having time to dig further more in this.