search

EGI-Federation / fedcloud-vmi-templates

Virtual Machine Image of EGI Fedcloud
Apache License 2.0
6 stars 5 forks source link

Update CentOS 7 #32

Closed enolfc closed 2 years ago

enolfc commented 2 years ago

Regular update as image expires now

enolfc commented 2 years ago

LGTM. Maybe we should find a better way to review this automatically, as I don't do any real check.

Yup. I think the minimal should be to check the shasum is correct, which is easy to do Going beyond that, it's getting complicated as we would need some way to start the VM or similar. Any suggestion?

gwarf commented 2 years ago

Checking the checksum may already be good, but it will likely result in a big download. In the future we could try to instantiate the VM to be sure it works, like with some of your terraform magic, but not sure it's worth to spend/invest time in it right now.