Confused about transpose of constraint matrix

EGiunchiglia / C-HMCNN

Code for paper: "Coherent Hierarchical Multi-Label Classification Networks"

GNU General Public License v3.0

85 stars 21 forks source link

Confused about transpose of constraint matrix #3

Closed utkutpcgl closed 2 years ago

utkutpcgl commented 2 years ago

Thanks for your work! For the output of get_constr_out to be correct, should not we take the transpose of the constraint matrix? The constrain matrix contains the ancestors at the last dimension, however, we want an ancestor to take the maximum of its descendants. https://github.com/EGiunchiglia/C-HMCNN/blob/ae8026517357abb69972a1d06f6481497ce00617/main.py#L27

EGiunchiglia commented 2 years ago

Hi! Sorry for the delayed reply.

I checked it and there were misleading comments in the main file. I have now changed them (plus I have added further clarifications). Let me know if that helps :)