search

EHDEN / CatalogueExport

Exports the data from the OMOP-CDM that is necessary for the EHDEN Database Catalogue
Apache License 2.0
9 stars 6 forks source link

.getSourceName called but its result is not assigned #21

Closed scossin closed 3 years ago

scossin commented 3 years ago

Describe the bug The bug is about the parameter sourceName (_String name of the data source name. If blank, CDMSOURCE table will be queried to try to obtain this). If sourceName is not given as parameter to the CatalogueExport::catalogueExport() function, .getSourceName is called to retrieve its value but the value it returns is not set to a variable so sourceName remains empty. https://github.com/EHDEN/CatalogueExport/blob/a7cdbd86e916e43ba1b67714236fc1eaf57b6320/R/CatalogueExport.R#L145

To Reproduce Call CatalogueExport::catalogueExport() function without sourceName parameter

Expected behavior

  if (missing(sourceName) & !sqlOnly) {
sourceName <- .getSourceName(connectionDetails, cdmDatabaseSchema) 
  }
PRijnbeek commented 3 years ago

Thanks agreed.

PRijnbeek commented 3 years ago

Can you make a pull request for this fix

PRijnbeek commented 3 years ago

will be closed when merged in Master