search

EHDEN / CatalogueExport

Exports the data from the OMOP-CDM that is necessary for the EHDEN Database Catalogue
Apache License 2.0
9 stars 6 forks source link

Incorrect Syntax Near ')' #30

Closed ericaVoss closed 3 years ago

ericaVoss commented 3 years ago

Describe the bug When Praveen is fully specifying the catalogueExport() function it is throwing an error

To Reproduce image

Expected behavior Generates proper SQL

Screenshots image

I'm guessing because he is throwing in an empty object, the SQL isn't building right: https://github.com/EHDEN/CatalogueExport/blob/f81edcd7510add2789bb4cb33beaefe2e84eebb1/inst/sql/sql_server/analyses/create_analysis_table.sql#L7

image

Additional context @PRijnbeek - I'm sure this isn't a bug, just maybe we are calling the function incorrectly

PRijnbeek commented 3 years ago

There is a ) at the beginning of the line of dropScratchTables the comma before that it will not like.

This is not a bug

ericaVoss commented 3 years ago

Agreed, closing