EHDEN / CatalogueExport

Exports the data from the OMOP-CDM that is necessary for the EHDEN Database Catalogue
Apache License 2.0
9 stars 6 forks source link

Change default value of `smallCellCount` #37

Open MaximMoinat opened 2 years ago

MaximMoinat commented 2 years ago

Is your feature request related to a problem? Please describe. Related to the question in the discussion reported here: https://github.com/EHDEN/CatalogueExport/discussions/36 The small cell count is applied after the rounding to the nearest 100. This means, that at a default smallCellCount of 5, none of the counts are filtered out and displayed as 100. Users probably don't expect that the CatalogueExport will actually show the codes that occur less frequently than the smallCellCount.

Describe the solution you'd like Easy temporary solution: Change the smallCellCount default value to 100.

Proper solution: Apply the small cell count to the original count value, before rounding up to nearest 100. This can be done by keeping the original count in each analysis and at the merge step apply the small cell count on that original count.