xx30 analysis use cdm schema for vocabulary tables

EHDEN / CatalogueExport

Exports the data from the OMOP-CDM that is necessary for the EHDEN Database Catalogue

Apache License 2.0

9 stars 6 forks source link

xx30 analysis use cdm schema for vocabulary tables #55

Open MaximMoinat opened 1 year ago

MaximMoinat commented 1 year ago

The xx30 scripts use @cdmDatabaseSchema for vocabulary tables. https://github.com/EHDEN/CatalogueExport/blob/066b8e7005890ae916e19a92a61c815e1fec7ff8/inst/sql/sql_server/analyses/430.sql#L9

These should be changed to @vocabDatabaseSchema.

RomainTching commented 1 year ago

Hello @MaximMoinat! I'm facing that issue right now, and having troubles fixing it even when trying to manually modify sqlOnly-produced files. Should I just reinstall the package from the dev branch where the fix was implemented, or would you suggest another approach?

MaximMoinat commented 1 year ago

Hi @RomainTching. Installing from dev is indeed the simplest solution (devtools::install_github("EHDEN/CatalogueExport", ref='dev'). Be aware this branch is not yet fully tested.

I will plan a new release, also including some other improvements.

MaximMoinat commented 1 year ago

Btw, another workaround is to create a view in your cdm schema: CREATE VIEW @cdmDatabaseSchema.CONCEPT_ANCESTOR AS (SELECT * FROM @vocabDatabaseSchema.CONCEPT_ANCESTOR)