Refactor mapped/unmapped sections (4.5 and 4.6)

EHDEN / CdmInspection

R Package to support quality control inspection of an OMOP-CDM instance

Apache License 2.0

11 stars 16 forks source link

Refactor mapped/unmapped sections (4.5 and 4.6) #25

Closed MaximMoinat closed 3 years ago

MaximMoinat commented 3 years ago

More descriptive table caption. This is repeated for every table.
Do not render the table if it is empty

Included a refactoring to reduce code duplication.

MaximMoinat commented 3 years ago

I think that is covered in the sql (only >10 are kept, before rounding).

https://github.com/EHDEN/CdmInspection/blob/8607fbe6966953067789e38f071b3e3e53462ba6/inst/sql/sql_server/checks/mapped_drugs.sql#L12-L15

PRijnbeek commented 3 years ago

Yes you are righ that may need to be a parameter so mincell count parameter of the function is used? or we remove the parameter ( do not think it is used anywhere else) and fix this to 10?

MaximMoinat commented 3 years ago

I see, we either remove the smallCellCount parameter or start using it. I would say, we use it everywhere as there is a use case in lowering this in order to get a full detailed report for internal use.